Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2991213003: scheduler: Make 'https://' optional in 'server' config field. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M scheduler/appengine/task/buildbucket/buildbucket.go View 5 chunks +13 lines, -4 lines 0 comments Download
M scheduler/appengine/task/buildbucket/buildbucket_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M scheduler/appengine/task/swarming/swarming.go View 6 chunks +14 lines, -5 lines 0 comments Download
M scheduler/appengine/task/swarming/swarming_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
See https://chromium-review.googlesource.com/c/597068 for rationale.
3 years, 4 months ago (2017-08-02 20:57:22 UTC) #1
tandrii(chromium)
lgtm
3 years, 4 months ago (2017-08-02 22:33:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991213003/1
3 years, 4 months ago (2017-08-02 23:23:13 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 23:29:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e74d1c071c854fc4b50e6d980f03164b03cdc61a

Powered by Google App Engine
This is Rietveld 408576698