Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: scheduler/appengine/task/buildbucket/buildbucket_test.go

Issue 2991213003: scheduler: Make 'https://' optional in 'server' config field. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scheduler/appengine/task/buildbucket/buildbucket.go ('k') | scheduler/appengine/task/swarming/swarming.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scheduler/appengine/task/buildbucket/buildbucket_test.go
diff --git a/scheduler/appengine/task/buildbucket/buildbucket_test.go b/scheduler/appengine/task/buildbucket/buildbucket_test.go
index 1e2b847baa16081d51214cd70025bd34d726f576..4a366eb58fce3bbabab7ed78c48f6eadc25ed191 100644
--- a/scheduler/appengine/task/buildbucket/buildbucket_test.go
+++ b/scheduler/appengine/task/buildbucket/buildbucket_test.go
@@ -46,7 +46,7 @@ func TestValidateProtoMessage(t *testing.T) {
Convey("ValidateProtoMessage passes good minimal msg", t, func() {
So(tm.ValidateProtoMessage(&messages.BuildbucketTask{
- Server: "https://blah.com",
+ Server: "blah.com",
Bucket: "bucket",
Builder: "builder",
}), ShouldBeNil)
@@ -70,7 +70,7 @@ func TestValidateProtoMessage(t *testing.T) {
}
So(call(""), ShouldErrLike, "field 'server' is required")
So(call("%%%%"), ShouldErrLike, "invalid URL")
- So(call("/abc"), ShouldErrLike, "not an absolute url")
+ So(call("/abc"), ShouldErrLike, "not a host root url")
So(call("https://host/not-root"), ShouldErrLike, "not a host root url")
})
« no previous file with comments | « scheduler/appengine/task/buildbucket/buildbucket.go ('k') | scheduler/appengine/task/swarming/swarming.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698