Issue 2991203002: Fix Observatory virtual-collection layout issues

Issue 2991203002: Fix Observatory virtual-collection layout issues (Closed)

Created:
3 years, 4 months ago by cbernaschina

Modified:
3 years, 4 months ago

Reviewers:
bkonyi, rmacnak

CC:
reviews_dartlang.org, rmacnak, turnidge, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix Observatory virtual-collection layout issues Virtual Collections especially in the allocation-profile page had some issues with layout and background coloring. R=bkonyi@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c39e7d5f5f628e335a0c7daba64317948278e325

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+258 lines, -201 lines)			Patch
M	runtime/observatory/lib/src/elements/allocation_profile.dart	View		1 chunk	+69 lines, -61 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/containers/virtual_collection.dart	View		7 chunks	+22 lines, -12 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/cpu_profile_table.dart	View		3 chunks	+48 lines, -26 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/css/shared.css	View		8 chunks	+35 lines, -28 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/memory_dashboard.dart	View		1 chunk	+69 lines, -61 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/persistent_handles.dart	View	1	1 chunk	+15 lines, -13 lines	0 comments	Download

Total messages: 8 (3 generated)

bkonyi

LGTM for the Dart code (I don't know enough about CSS to comment on that).

3 years, 4 months ago (2017-08-02 19:46:47 UTC) #5

cbernaschina

3 years, 4 months ago (2017-08-02 23:08:32 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c39e7d5f5f628e335a0c7daba64317948278e325 (presubmit successful).