Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: runtime/observatory/lib/src/elements/persistent_handles.dart

Issue 2991203002: Fix Observatory virtual-collection layout issues (Closed)
Patch Set: Fix persistent handles page Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/memory_dashboard.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/persistent_handles.dart
diff --git a/runtime/observatory/lib/src/elements/persistent_handles.dart b/runtime/observatory/lib/src/elements/persistent_handles.dart
index 2faad9fefed17e6a6c3bbef854b573811a07b5d4..bb4f665c1472497c3f23de21438ab17d5debe3aa 100644
--- a/runtime/observatory/lib/src/elements/persistent_handles.dart
+++ b/runtime/observatory/lib/src/elements/persistent_handles.dart
@@ -186,19 +186,21 @@ class PersistentHandlesPageElement extends HtmlElement implements Renderable {
..text = 'dart::Class::Method()'
];
- Element _createWeakHeader() => new DivElement()
- ..classes = ['weak-item']
- ..children = [
- _createHeaderButton(const ['external-size'], 'External Size',
- _SortingField.externalSize, _SortingDirection.descending),
- _createHeaderButton(const ['peer'], 'Peer', _SortingField.peer,
- _SortingDirection.descending),
- new SpanElement()
- ..classes = ['object']
- ..text = 'Object',
- _createHeaderButton(const ['finalizer'], 'Finalizer Callback',
- _SortingField.finalizerCallback, _SortingDirection.ascending)
- ];
+ List<HtmlElement> _createWeakHeader() => [
+ new DivElement()
+ ..classes = ['weak-item']
+ ..children = [
+ _createHeaderButton(const ['external-size'], 'External Size',
+ _SortingField.externalSize, _SortingDirection.descending),
+ _createHeaderButton(const ['peer'], 'Peer', _SortingField.peer,
+ _SortingDirection.descending),
+ new SpanElement()
+ ..classes = ['object']
+ ..text = 'Object',
+ _createHeaderButton(const ['finalizer'], 'Finalizer Callback',
+ _SortingField.finalizerCallback, _SortingDirection.ascending)
+ ]
+ ];
ButtonElement _createHeaderButton(List<String> classes, String text,
_SortingField field, _SortingDirection direction) =>
« no previous file with comments | « runtime/observatory/lib/src/elements/memory_dashboard.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698