Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/observatory/lib/src/elements/memory_dashboard.dart

Issue 2991203002: Fix Observatory virtual-collection layout issues (Closed)
Patch Set: Fix persistent handles page Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/css/shared.css ('k') | runtime/observatory/lib/src/elements/persistent_handles.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/memory_dashboard.dart
diff --git a/runtime/observatory/lib/src/elements/memory_dashboard.dart b/runtime/observatory/lib/src/elements/memory_dashboard.dart
index 28181bb7c5466cb33ccec34c8daf7af7ae95bd87..2f0e85327f7c1268eea4340d45759d1c270a463c 100644
--- a/runtime/observatory/lib/src/elements/memory_dashboard.dart
+++ b/runtime/observatory/lib/src/elements/memory_dashboard.dart
@@ -354,67 +354,75 @@ class MemoryDashboardElement extends HtmlElement implements Renderable {
new SpanElement()..classes = ['name']
];
- Element _createCollectionHeader() => new DivElement()
- ..children = [
- new DivElement()
- ..classes = ['collection-item']
- ..children = [
- new SpanElement()
- ..classes = ['group']
- ..text = 'Accumulated',
- new SpanElement()
- ..classes = ['group']
- ..text = 'Current',
- new SpanElement()
- ..classes = ['group']
- ..text = '(NEW) Accumulated',
- new SpanElement()
- ..classes = ['group']
- ..text = '(NEW) Current',
- new SpanElement()
- ..classes = ['group']
- ..text = '(OLD) Accumulated',
- new SpanElement()
- ..classes = ['group']
- ..text = '(OLD) Current',
- ],
- new DivElement()
- ..classes = ['collection-item']
- ..children = [
- _createHeaderButton(const ['bytes'], 'Size',
- _SortingField.accumulatedSize, _SortingDirection.descending),
- _createHeaderButton(const ['instances'], 'Instances',
- _SortingField.accumulatedInstances, _SortingDirection.descending),
- _createHeaderButton(const ['bytes'], 'Size',
- _SortingField.currentSize, _SortingDirection.descending),
- _createHeaderButton(const ['instances'], 'Instances',
- _SortingField.currentInstances, _SortingDirection.descending),
- _createHeaderButton(const ['bytes'], 'Size',
- _SortingField.newAccumulatedSize, _SortingDirection.descending),
- _createHeaderButton(
- const ['instances'],
- 'Instances',
- _SortingField.newAccumulatedInstances,
- _SortingDirection.descending),
- _createHeaderButton(const ['bytes'], 'Size',
- _SortingField.newCurrentSize, _SortingDirection.descending),
- _createHeaderButton(const ['instances'], 'Instances',
- _SortingField.newCurrentInstances, _SortingDirection.descending),
- _createHeaderButton(const ['bytes'], 'Size',
- _SortingField.oldAccumulatedSize, _SortingDirection.descending),
- _createHeaderButton(
- const ['instances'],
- 'Instances',
- _SortingField.oldAccumulatedInstances,
- _SortingDirection.descending),
- _createHeaderButton(const ['bytes'], 'Size',
- _SortingField.oldCurrentSize, _SortingDirection.descending),
- _createHeaderButton(const ['instances'], 'Instances',
- _SortingField.oldCurrentInstances, _SortingDirection.descending),
- _createHeaderButton(const ['name'], 'Class', _SortingField.className,
- _SortingDirection.ascending)
- ],
- ];
+ List<HtmlElement> _createCollectionHeader() => [
+ new DivElement()
+ ..classes = ['collection-item']
+ ..children = [
+ new SpanElement()
+ ..classes = ['group']
+ ..text = 'Accumulated',
+ new SpanElement()
+ ..classes = ['group']
+ ..text = 'Current',
+ new SpanElement()
+ ..classes = ['group']
+ ..text = '(NEW) Accumulated',
+ new SpanElement()
+ ..classes = ['group']
+ ..text = '(NEW) Current',
+ new SpanElement()
+ ..classes = ['group']
+ ..text = '(OLD) Accumulated',
+ new SpanElement()
+ ..classes = ['group']
+ ..text = '(OLD) Current',
+ ],
+ new DivElement()
+ ..classes = ['collection-item']
+ ..children = [
+ _createHeaderButton(const ['bytes'], 'Size',
+ _SortingField.accumulatedSize, _SortingDirection.descending),
+ _createHeaderButton(
+ const ['instances'],
+ 'Instances',
+ _SortingField.accumulatedInstances,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['bytes'], 'Size',
+ _SortingField.currentSize, _SortingDirection.descending),
+ _createHeaderButton(const ['instances'], 'Instances',
+ _SortingField.currentInstances, _SortingDirection.descending),
+ _createHeaderButton(const ['bytes'], 'Size',
+ _SortingField.newAccumulatedSize, _SortingDirection.descending),
+ _createHeaderButton(
+ const ['instances'],
+ 'Instances',
+ _SortingField.newAccumulatedInstances,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['bytes'], 'Size',
+ _SortingField.newCurrentSize, _SortingDirection.descending),
+ _createHeaderButton(
+ const ['instances'],
+ 'Instances',
+ _SortingField.newCurrentInstances,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['bytes'], 'Size',
+ _SortingField.oldAccumulatedSize, _SortingDirection.descending),
+ _createHeaderButton(
+ const ['instances'],
+ 'Instances',
+ _SortingField.oldAccumulatedInstances,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['bytes'], 'Size',
+ _SortingField.oldCurrentSize, _SortingDirection.descending),
+ _createHeaderButton(
+ const ['instances'],
+ 'Instances',
+ _SortingField.oldCurrentInstances,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['name'], 'Class',
+ _SortingField.className, _SortingDirection.ascending)
+ ],
+ ];
ButtonElement _createHeaderButton(List<String> classes, String text,
_SortingField field, _SortingDirection direction) =>
« no previous file with comments | « runtime/observatory/lib/src/elements/css/shared.css ('k') | runtime/observatory/lib/src/elements/persistent_handles.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698