Add support for super initialziers in constructor initializer list

Add support for super initializers in constructor initializer list


BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/4aab6a4a494874f78042a4e492981c2f9870aaa5

[zhivkag, 2017-07-28 10:21:33]

Description was changed from

==========
Add support for super initialziers in constructor initializer list

BUG=
==========

to

==========
Add support for super initializers in constructor initializer list


BUG=
==========

[zhivkag, 2017-07-28 10:21:33]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[zhivkag, 2017-07-28 10:23:02]

Support for redirecting constructors will be added similarly, but in a followup
CL.

[Dmitry Stefantsov, 2017-08-02 15:05:49]

LGTM.  I have a couple of remarks though :)

https://codereview.chromium.org/2990943002/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2990943002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:718: // (i.e., Field or Local
initializer) or a Super initializer.
Please, see if the changes from the previous updated CL persist after landing
this one.  I remember leaving notes about this comment and some lines below.

https://codereview.chromium.org/2990943002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:750: var cont = new
InitializerListEK(constructor, 0 /* initializerIndex*/,
How about putting this in-line comment to its own line above with an
explanation, why the index is 0 here?

[zhivkag, 2017-08-02 15:25:40]

https://codereview.chromium.org/2990943002/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2990943002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:718: // (i.e., Field or Local
initializer) or a Super initializer.
On 2017/08/02 15:05:49, Dmitry Stefantsov wrote:
> Please, see if the changes from the previous updated CL persist after landing
> this one.  I remember leaving notes about this comment and some lines below.

Done.

https://codereview.chromium.org/2990943002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:750: var cont = new
InitializerListEK(constructor, 0 /* initializerIndex*/,
On 2017/08/02 15:05:49, Dmitry Stefantsov wrote:
> How about putting this in-line comment to its own line above with an
> explanation, why the index is 0 here?

Done.

[zhivkag, 2017-08-03 07:00:25]

Description was changed from

==========
Add support for super initializers in constructor initializer list


BUG=
==========

to

==========
Add support for super initializers in constructor initializer list


BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4aab6a4a494874f78042a4e492981c2f9870aaa5
==========

[zhivkag, 2017-08-03 07:00:27]

Committed patchset #4 (id:60001) manually as
4aab6a4a494874f78042a4e492981c2f9870aaa5 (presubmit successful).