Add support for initializers in constructor invocation

Add support for initializers in constructor invocation

This adds support for field and local initialziers
for constructor invocation.

BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/66426a2b1c0fd598e7d2181cb31b6dd2ffaea810

[zhivkag, 2017-07-28 06:21:47]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[Dmitry Stefantsov, 2017-08-02 10:27:19]

LGTM if you respond to the comments.

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:694: // (i.e., Field or Local
initializer) or a Super initializer.
On my first read I get this comment as "we can't have a field initializer or a
local initializer before a super initializer", but I think what was meant is
"First, we consider the base case, where there are no field initializers or
local initializers before a super initializer, or there are no initializers at
all."

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1036: /// `index`.
Here "index" is a reference to an identifier, so it's better to write it as
[index].

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1060: // TODO(zhivkag): Execute
`object` constructor when support for
"object" here is not a code fragment (as I get it), so it shouldn't be formatted
with backticks.

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1068: throw 'Support for
SuperInitializers in not implemented.';
Just a curiosity question: why string literals are sometimes defined with single
quotes and sometimes with double quotes?

[zhivkag, 2017-08-02 10:56:05]

Thanks!

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:694: // (i.e., Field or Local
initializer) or a Super initializer.
On 2017/08/02 10:27:19, Dmitry Stefantsov wrote:
> On my first read I get this comment as "we can't have a field initializer or a
> local initializer before a super initializer", but I think what was meant is
> "First, we consider the base case, where there are no field initializers or
> local initializers before a super initializer, or there are no initializers at
> all."

I removed the comment. Its intent was not to explain the "if" condition, but
rather mention that we can assume the first initializer (if any) can not be a
RedirectingInitializer.

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1036: /// `index`.
On 2017/08/02 10:27:19, Dmitry Stefantsov wrote:
> Here "index" is a reference to an identifier, so it's better to write it as
> [index].

Done.

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1060: // TODO(zhivkag): Execute
`object` constructor when support for
On 2017/08/02 10:27:19, Dmitry Stefantsov wrote:
> "object" here is not a code fragment (as I get it), so it shouldn't be
formatted
> with backticks.

Done.

https://codereview.chromium.org/2986973002/diff/60001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1068: throw 'Support for
SuperInitializers in not implemented.';
On 2017/08/02 10:27:19, Dmitry Stefantsov wrote:
> Just a curiosity question: why string literals are sometimes defined with
single
> quotes and sometimes with double quotes?

Sometimes I use double quotes when the string contains a single quote character.
I probably have used them interchangeably in some other places.

[zhivkag, 2017-08-02 10:57:31]

Description was changed from

==========
Add support for initializers in constructor invocation

This adds support for field and local initialziers
for constructor invocation.

BUG=
==========

to

==========
Add support for initializers in constructor invocation

This adds support for field and local initialziers
for constructor invocation.

BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/66426a2b1c0fd598e7d2181cb31b6dd2ffaea810
==========

[zhivkag, 2017-08-02 10:57:32]

Committed patchset #5 (id:80001) manually as
66426a2b1c0fd598e7d2181cb31b6dd2ffaea810 (presubmit successful).