Add support for redirecting constructors

Add support for redirecting constructors

BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/a04c14da7d0813ec475a24c5e6c38cbcb680e9a7

[zhivkag, 2017-07-31 07:13:23]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[zhivkag, 2017-07-31 07:13:25]

This adds support for redirecting constructors by evaluating a redirecting
initializer in the constructor's initializer list.

[Dmitry Stefantsov, 2017-08-03 08:34:08]

LGTM with a few nitpicky comments :)

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:714: // This can happen when
initializing fields of Ctr with empty initializer
One of the following substitutions would be helpful:
  * Ctr ==> a constructor
  * Ctr ==> [constructor]

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1066: // eval list of args with
current env
Please, make a full sentence out of this comment.

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1077: var cont = new
InitializerListEK(constructor, 0 /* initializerIndex*/,
Ignore this comment if it was already done in a previous CL :)

Please, put this in-line comment to its own line above.

[Dmitry Stefantsov, 2017-08-03 08:34:09]

LGTM with a few nitpicky comments :)

[zhivkag, 2017-08-03 08:46:52]

Suggestions applied - thanks!

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:714: // This can happen when
initializing fields of Ctr with empty initializer
On 2017/08/03 08:34:08, Dmitry Stefantsov wrote:
> One of the following substitutions would be helpful:
>   * Ctr ==> a constructor
>   * Ctr ==> [constructor]

Done.

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1066: // eval list of args with
current env
On 2017/08/03 08:34:08, Dmitry Stefantsov wrote:
> Please, make a full sentence out of this comment.

Done.

https://codereview.chromium.org/2984423002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1077: var cont = new
InitializerListEK(constructor, 0 /* initializerIndex*/,
On 2017/08/03 08:34:08, Dmitry Stefantsov wrote:
> Ignore this comment if it was already done in a previous CL :)
> 
> Please, put this in-line comment to its own line above.

I probably lost it in the merge, added again :)

[zhivkag, 2017-08-03 09:12:27]

Description was changed from

==========
Add support for redirecting constructors

BUG=
==========

to

==========
Add support for redirecting constructors

BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a04c14da7d0813ec475a24c5e6c38cbcb680e9a7
==========

[zhivkag, 2017-08-03 09:12:29]

Committed patchset #6 (id:100001) manually as
a04c14da7d0813ec475a24c5e6c38cbcb680e9a7 (presubmit successful).