Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: Source/core/animation/EffectInput.cpp

Issue 299073003: Web Animations API: Avoid style resolution when calling element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove checkDocumentAndRenderer as it is no longer needed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/EffectInput.h ('k') | Source/core/animation/EffectInputTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/EffectInput.cpp
diff --git a/Source/core/animation/EffectInput.cpp b/Source/core/animation/EffectInput.cpp
index 15fb5f682b65e82856227d5d74302c63ca2f3200..6d879fe9756cc84409a17bbdb5d9b21654ab5559 100644
--- a/Source/core/animation/EffectInput.cpp
+++ b/Source/core/animation/EffectInput.cpp
@@ -42,22 +42,8 @@
namespace WebCore {
-// FIXME: Remove this once we've removed the dependency on Element.
alancutter (OOO until 2018) 2014/06/01 08:10:01 We should keep a FIXME for the dependency on Eleme
dstockwell 2014/06/01 23:59:31 What is the dependency on element that we still ha
-static bool checkDocumentAndRenderer(Element* element)
+PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState)
{
- if (!element || !element->inActiveDocument())
- return false;
- element->document().updateRenderTreeIfNeeded();
- return element->renderer();
-}
-
-PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState, bool unsafe)
-{
- // FIXME: This test will not be neccessary once resolution of keyframe values occurs at
- // animation application time.
- if (!unsafe && !checkDocumentAndRenderer(element))
- return nullptr;
-
StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();
StringKeyframeVector keyframes;
bool everyFrameHasOffset = true;
« no previous file with comments | « Source/core/animation/EffectInput.h ('k') | Source/core/animation/EffectInputTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698