Web Animations API: Avoid style resolution when calling element.animate()

Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
 #include "core/animation/AnimationHelpers.h"
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/StringKeyframe.h"
 #include "core/css/parser/BisonCSSParser.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/Element.h"
 #include "wtf/NonCopyingSort.h"
 
 namespace WebCore {
 
-// FIXME: Remove this once we've removed the dependency on Element.

[alancutter (OOO until 2018), 2014/06/01 08:10:01]

We should keep a FIXME for the dependency on Element that we still have.

[dstockwell, 2014/06/01 23:59:31]

What is the dependency on element that we still have? Can we just remove it now?

-static bool checkDocumentAndRenderer(Element* element)
+PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState)
 {
-    if (!element || !element->inActiveDocument())
-        return false;
-    element->document().updateRenderTreeIfNeeded();
-    return element->renderer();
-}
-
-PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState, bool unsafe)
-{
-    // FIXME: This test will not be neccessary once resolution of keyframe values occurs at
-    // animation application time.
-    if (!unsafe && !checkDocumentAndRenderer(element))
-        return nullptr;
-
     StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();
     StringKeyframeVector keyframes;
     bool everyFrameHasOffset = true;
     bool looselySortedByOffset = true;
     double lastOffset = -std::numeric_limits<double>::infinity();
 
     for (size_t i = 0; i < keyframeDictionaryVector.size(); ++i) {
         RefPtrWillBeRawPtr<StringKeyframe> keyframe = StringKeyframe::create();
 
         bool frameHasOffset = false;
@@ skipping 57 matching lines @@
     if (!keyframeEffectModel->isReplaceOnly()) {
         exceptionState.throwDOMException(NotSupportedError, "Partial keyframes are not supported.");
         return nullptr;
     }
     keyframeEffectModel->forceConversionsToAnimatableValues(element);
 
     return keyframeEffectModel;
 }
 
 } // namespace WebCore