Source/core/animation/EffectInputTest.cpp - Issue 299073003: Web Animations API: Avoid style resolution when calling element.animate()

Unified Diff: Source/core/animation/EffectInputTest.cpp

Issue 299073003: Web Animations API: Avoid style resolution when calling element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove checkDocumentAndRenderer as it is no longer needed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/EffectInputTest.cpp

diff --git a/Source/core/animation/EffectInputTest.cpp b/Source/core/animation/EffectInputTest.cpp

index 34dbb56162a7a0d5a04b3e7616b61af7e2a233f8..18cb2f3bcb9b841185413403e7b51104f134c748 100644

--- a/Source/core/animation/EffectInputTest.cpp

+++ b/Source/core/animation/EffectInputTest.cpp

@@ -50,7 +50,7 @@ TEST_F(AnimationEffectInputTest, SortedOffsets)

jsKeyframes.append(Dictionary(keyframe1, m_isolate));

jsKeyframes.append(Dictionary(keyframe2, m_isolate));

- RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);

+ RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState);

EXPECT_FALSE(exceptionState.hadException());

const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());

EXPECT_EQ(1.0, keyframeEffect.getFrames()[1]->offset());

@@ -70,7 +70,7 @@ TEST_F(AnimationEffectInputTest, UnsortedOffsets)

jsKeyframes.append(Dictionary(keyframe1, m_isolate));

jsKeyframes.append(Dictionary(keyframe2, m_isolate));

- RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);

+ RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState);

EXPECT_FALSE(exceptionState.hadException());

const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());

EXPECT_EQ(1.0, keyframeEffect.getFrames()[1]->offset());

@@ -93,7 +93,7 @@ TEST_F(AnimationEffectInputTest, LooslySorted)

jsKeyframes.append(Dictionary(keyframe2, m_isolate));

jsKeyframes.append(Dictionary(keyframe3, m_isolate));

- RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);

+ RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState);

EXPECT_FALSE(exceptionState.hadException());

const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());

EXPECT_EQ(1, keyframeEffect.getFrames()[2]->offset());

@@ -117,7 +117,7 @@ TEST_F(AnimationEffectInputTest, Invalid)

jsKeyframes.append(Dictionary(keyframe2, m_isolate));

jsKeyframes.append(Dictionary(keyframe3, m_isolate));

- RefPtrWillBeRawPtr<AnimationEffect> animationEffect ALLOW_UNUSED = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);

+ RefPtrWillBeRawPtr<AnimationEffect> animationEffect ALLOW_UNUSED = EffectInput::convert(element.get(), jsKeyframes, exceptionState);

EXPECT_TRUE(exceptionState.hadException());

EXPECT_EQ(InvalidModificationError, exceptionState.code());

}

« Source/core/animation/EffectInput.cpp ('K') | « Source/core/animation/EffectInput.cpp ('k') | no next file » | no next file with comments »