Move byte_store.dart and file_byte_store.dart to their own subdirectory.

Move byte_store.dart and file_byte_store.dart to their own subdirectory.

This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.

R=scheglov@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/89c910b9c1ed5dad3f432cc1a9ef13f6b9145186

[Paul Berry, 2017-08-07 17:35:49]

paulberry@google.com changed reviewers:
+ scheglov@google.com, sigmund@google.com

[scheglov, 2017-08-07 17:37:33]

LGTM

[Siggi Cherem (dart-lang), 2017-08-07 17:44:05]

lgtm

https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:63: 'lib/src/byte_store':
new SubpackageRules(allowedDependencies: []),
let's add a comment here to say that this folder should never have a dep to
lib/src/fasta/?

(I find some dependencies are OK to add, some are a sign that we are doing
something wrong, a comment will help that adding a dep to fasta is something
wrong)

[Paul Berry, 2017-08-07 17:48:03]

https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:63: 'lib/src/byte_store':
new SubpackageRules(allowedDependencies: []),
On 2017/08/07 17:44:05, Siggi Cherem (dart-lang) wrote:
> let's add a comment here to say that this folder should never have a dep to
> lib/src/fasta/?
> 
> (I find some dependencies are OK to add, some are a sign that we are doing
> something wrong, a comment will help that adding a dep to fasta is something
> wrong)

Done.

[Paul Berry, 2017-08-07 18:04:52]

Description was changed from

==========
Move byte_store.dart and file_byte_store.dart to their own subdirectory.

This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.
==========

to

==========
Move byte_store.dart and file_byte_store.dart to their own subdirectory.

This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.

R=scheglov@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/89c910b9c1ed5dad3f432cc1a9ef13f6b9145186
==========

[Paul Berry, 2017-08-07 18:04:54]

Committed patchset #1 (id:1) manually as
89c910b9c1ed5dad3f432cc1a9ef13f6b9145186 (presubmit successful).

[ahe, 2017-08-08 14:00:00]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-08-08 14:00:01]

FYI/DBC

https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:63: 'lib/src/byte_store':
new SubpackageRules(allowedDependencies: []),
On 2017/08/07 17:48:03, Paul Berry wrote:
> On 2017/08/07 17:44:05, Siggi Cherem (dart-lang) wrote:
> > let's add a comment here to say that this folder should never have a dep to
> > lib/src/fasta/?
> > 
> > (I find some dependencies are OK to add, some are a sign that we are doing
> > something wrong, a comment will help that adding a dep to fasta is something
> > wrong)
> 
> Done.

But that's not what Paul said was the intent of this CL. For this library to
become its own package, it shouldn't depend on other parts of front_end. What am
I missing?

[Paul Berry, 2017-08-08 14:11:06]

On 2017/08/08 14:00:01, ahe wrote:
> FYI/DBC
> 
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> File pkg/front_end/test/subpackage_relationships_test.dart (right):
> 
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> pkg/front_end/test/subpackage_relationships_test.dart:63:
'lib/src/byte_store':
> new SubpackageRules(allowedDependencies: []),
> On 2017/08/07 17:48:03, Paul Berry wrote:
> > On 2017/08/07 17:44:05, Siggi Cherem (dart-lang) wrote:
> > > let's add a comment here to say that this folder should never have a dep
to
> > > lib/src/fasta/?
> > > 
> > > (I find some dependencies are OK to add, some are a sign that we are doing
> > > something wrong, a comment will help that adding a dep to fasta is
something
> > > wrong)
> > 
> > Done.
> 
> But that's not what Paul said was the intent of this CL. For this library to
> become its own package, it shouldn't depend on other parts of front_end. What
am
> I missing?

Yes, I agree, and I interpreted Siggi's intent as something consistent with
that.  I assumed that when he said "lib/src/fasta/", he meant "the rest of the
front_end", momentarily forgetting that there are other parts of the front_end
that are outside of fasta.  Perhaps that interpretation was wishful thinking on
my part?

Siggi, here is the comment I added.  Does it seem ok to you or does it
misrepresent what you were asking for?  I said:

// Note: byte_store should never depend on other parts of front_end, since we
// may want to move it to its own package someday.

[ahe, 2017-08-08 14:26:49]

On 2017/08/08 14:11:06, Paul Berry wrote:
> On 2017/08/08 14:00:01, ahe wrote:
> > FYI/DBC
> > 
> >
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> > File pkg/front_end/test/subpackage_relationships_test.dart (right):
> > 
> >
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> > pkg/front_end/test/subpackage_relationships_test.dart:63:
> 'lib/src/byte_store':
> > new SubpackageRules(allowedDependencies: []),
> > On 2017/08/07 17:48:03, Paul Berry wrote:
> > > On 2017/08/07 17:44:05, Siggi Cherem (dart-lang) wrote:
> > > > let's add a comment here to say that this folder should never have a dep
> to
> > > > lib/src/fasta/?
> > > > 
> > > > (I find some dependencies are OK to add, some are a sign that we are
doing
> > > > something wrong, a comment will help that adding a dep to fasta is
> something
> > > > wrong)
> > > 
> > > Done.
> > 
> > But that's not what Paul said was the intent of this CL. For this library to
> > become its own package, it shouldn't depend on other parts of front_end.
What
> am
> > I missing?
> 
> Yes, I agree, and I interpreted Siggi's intent as something consistent with
> that.  I assumed that when he said "lib/src/fasta/", he meant "the rest of the
> front_end", momentarily forgetting that there are other parts of the front_end
> that are outside of fasta.  Perhaps that interpretation was wishful thinking
on
> my part?
> 
> Siggi, here is the comment I added.  Does it seem ok to you or does it
> misrepresent what you were asking for?  I said:
> 
> // Note: byte_store should never depend on other parts of front_end, since we
> // may want to move it to its own package someday.

Great :-)

FWIW, I think it's a great idea to add comments like that to
subpackage_relationships_test.

[Siggi Cherem (dart-lang), 2017-08-08 21:27:00]

On 2017/08/08 14:26:49, ahe wrote:
> On 2017/08/08 14:11:06, Paul Berry wrote:
> > On 2017/08/08 14:00:01, ahe wrote:
> > > FYI/DBC
> > > 
> > >
> >
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> > > File pkg/front_end/test/subpackage_relationships_test.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> > > pkg/front_end/test/subpackage_relationships_test.dart:63:
> > 'lib/src/byte_store':
> > > new SubpackageRules(allowedDependencies: []),
> > > On 2017/08/07 17:48:03, Paul Berry wrote:
> > > > On 2017/08/07 17:44:05, Siggi Cherem (dart-lang) wrote:
> > > > > let's add a comment here to say that this folder should never have a
dep
> > to
> > > > > lib/src/fasta/?
> > > > > 
> > > > > (I find some dependencies are OK to add, some are a sign that we are
> doing
> > > > > something wrong, a comment will help that adding a dep to fasta is
> > something
> > > > > wrong)
> > > > 
> > > > Done.
> > > 
> > > But that's not what Paul said was the intent of this CL. For this library
to
> > > become its own package, it shouldn't depend on other parts of front_end.
> What
> > am
> > > I missing?
> > 
> > Yes, I agree, and I interpreted Siggi's intent as something consistent with
> > that.  I assumed that when he said "lib/src/fasta/", he meant "the rest of
the
> > front_end", momentarily forgetting that there are other parts of the
front_end
> > that are outside of fasta.  Perhaps that interpretation was wishful thinking
> on
> > my part?
> > 
> > Siggi, here is the comment I added.  Does it seem ok to you or does it
> > misrepresent what you were asking for?  I said:
> > 
> > // Note: byte_store should never depend on other parts of front_end, since
we
> > // may want to move it to its own package someday.
> 
> Great :-)
> 
> FWIW, I think it's a great idea to add comments like that to
> subpackage_relationships_test.

Thanks - the comment is great. Indeed, I meant the rest of FE :)