Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 2990323002: Move byte_store.dart and file_byte_store.dart to their own subdirectory. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move byte_store.dart and file_byte_store.dart to their own subdirectory. This allows us to use the subpackage relationships test to verify that they don't import any other parts of front_end, which paves the way for the possibility of moving them to their own package in the future. R=scheglov@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/89c910b9c1ed5dad3f432cc1a9ef13f6b9145186

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -438 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_watcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/lint/analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/compiler_options.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/base/processed_options.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/front_end/lib/src/byte_store/byte_store.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/front_end/lib/src/byte_store/file_byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/incremental/byte_store.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D pkg/front_end/lib/src/incremental/file_byte_store.dart View 1 chunk +0 lines, -171 lines 0 comments Download
M pkg/front_end/lib/src/incremental/file_state.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/incremental/kernel_driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/front_end/test/src/byte_store/byte_store_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/test/src/incremental/byte_store_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M pkg/front_end/test/src/incremental/file_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/src/incremental/kernel_driver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/src/incremental/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 3 chunks +4 lines, -2 lines 3 comments Download

Messages

Total messages: 12 (3 generated)
Paul Berry
3 years, 4 months ago (2017-08-07 17:35:50 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-07 17:37:33 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart File pkg/front_end/test/subpackage_relationships_test.dart (right): https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart#newcode63 pkg/front_end/test/subpackage_relationships_test.dart:63: 'lib/src/byte_store': new SubpackageRules(allowedDependencies: []), let's add a comment ...
3 years, 4 months ago (2017-08-07 17:44:05 UTC) #4
Paul Berry
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart File pkg/front_end/test/subpackage_relationships_test.dart (right): https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart#newcode63 pkg/front_end/test/subpackage_relationships_test.dart:63: 'lib/src/byte_store': new SubpackageRules(allowedDependencies: []), On 2017/08/07 17:44:05, Siggi Cherem ...
3 years, 4 months ago (2017-08-07 17:48:03 UTC) #5
Paul Berry
Committed patchset #1 (id:1) manually as 89c910b9c1ed5dad3f432cc1a9ef13f6b9145186 (presubmit successful).
3 years, 4 months ago (2017-08-07 18:04:54 UTC) #7
ahe
FYI/DBC https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart File pkg/front_end/test/subpackage_relationships_test.dart (right): https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart#newcode63 pkg/front_end/test/subpackage_relationships_test.dart:63: 'lib/src/byte_store': new SubpackageRules(allowedDependencies: []), On 2017/08/07 17:48:03, Paul ...
3 years, 4 months ago (2017-08-08 14:00:01 UTC) #9
Paul Berry
On 2017/08/08 14:00:01, ahe wrote: > FYI/DBC > > https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpackage_relationships_test.dart > File pkg/front_end/test/subpackage_relationships_test.dart (right): > ...
3 years, 4 months ago (2017-08-08 14:11:06 UTC) #10
ahe
On 2017/08/08 14:11:06, Paul Berry wrote: > On 2017/08/08 14:00:01, ahe wrote: > > FYI/DBC ...
3 years, 4 months ago (2017-08-08 14:26:49 UTC) #11
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-08 21:27:00 UTC) #12
Message was sent while issue was closed.
On 2017/08/08 14:26:49, ahe wrote:
> On 2017/08/08 14:11:06, Paul Berry wrote:
> > On 2017/08/08 14:00:01, ahe wrote:
> > > FYI/DBC
> > > 
> > >
> >
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> > > File pkg/front_end/test/subpackage_relationships_test.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2990323002/diff/1/pkg/front_end/test/subpacka...
> > > pkg/front_end/test/subpackage_relationships_test.dart:63:
> > 'lib/src/byte_store':
> > > new SubpackageRules(allowedDependencies: []),
> > > On 2017/08/07 17:48:03, Paul Berry wrote:
> > > > On 2017/08/07 17:44:05, Siggi Cherem (dart-lang) wrote:
> > > > > let's add a comment here to say that this folder should never have a
dep
> > to
> > > > > lib/src/fasta/?
> > > > > 
> > > > > (I find some dependencies are OK to add, some are a sign that we are
> doing
> > > > > something wrong, a comment will help that adding a dep to fasta is
> > something
> > > > > wrong)
> > > > 
> > > > Done.
> > > 
> > > But that's not what Paul said was the intent of this CL. For this library
to
> > > become its own package, it shouldn't depend on other parts of front_end.
> What
> > am
> > > I missing?
> > 
> > Yes, I agree, and I interpreted Siggi's intent as something consistent with
> > that.  I assumed that when he said "lib/src/fasta/", he meant "the rest of
the
> > front_end", momentarily forgetting that there are other parts of the
front_end
> > that are outside of fasta.  Perhaps that interpretation was wishful thinking
> on
> > my part?
> > 
> > Siggi, here is the comment I added.  Does it seem ok to you or does it
> > misrepresent what you were asking for?  I said:
> > 
> > // Note: byte_store should never depend on other parts of front_end, since
we
> > // may want to move it to its own package someday.
> 
> Great :-)
> 
> FWIW, I think it's a great idea to add comments like that to
> subpackage_relationships_test.

Thanks - the comment is great. Indeed, I meant the rest of FE :)

Powered by Google App Engine
This is Rietveld 408576698