Move byte_store.dart and file_byte_store.dart to their own subdirectory.

pkg/front_end/test/subpackage_relationships_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:front_end/compiler_options.dart';
 import 'package:front_end/dependency_grapher.dart';
 import 'package:path/path.dart' as pathos;
@@ skipping 23 matching lines @@
 ///
 /// Each listed directory is considered a subpackage.  Each package contains all
 /// of its descendant files that are not in a more deeply nested subpackage.
 ///
 /// TODO(paulberry): stuff in lib/src shouldn't depend on lib; lib should just
 /// re-export stuff in lib/src.
 final subpackageRules = {
   'lib': new SubpackageRules(allowedDependencies: [
     'lib/src',
     'lib/src/base',
+    'lib/src/byte_store',
     'lib/src/fasta',
-    'lib/src/incremental',
   ]),
   'lib/src': new SubpackageRules(allowedDependencies: [
     'lib',
     'lib/src/base',
     'lib/src/fasta',
     "lib/src/fasta/dill",
     "lib/src/fasta/kernel",
     'lib/src/fasta/source',
     'lib/src/incremental',
   ]),
   'lib/src/base': new SubpackageRules(allowedDependencies: [
     'lib',
     'lib/src',
+    'lib/src/byte_store',
     'lib/src/fasta',
     'lib/src/fasta/util',
-    'lib/src/incremental'
   ]),
+  'lib/src/byte_store': new SubpackageRules(allowedDependencies: []),

[Siggi Cherem (dart-lang), 2017/08/07 17:44:05]

let's add a comment here to say that this folder should never have a dep to
lib/src/fasta/?

(I find some dependencies are OK to add, some are a sign that we are doing
something wrong, a comment will help that adding a dep to fasta is something
wrong)

[Paul Berry, 2017/08/07 17:48:03]

Done.

[ahe, 2017/08/08 14:00:00]

But that's not what Paul said was the intent of this CL. For this library to
become its own package, it shouldn't depend on other parts of front_end. What am
I missing?

   'lib/src/codegen': new SubpackageRules(),
   'lib/src/fasta': new SubpackageRules(allowedDependencies: [
     'lib',
     'lib/src',
     'lib/src/base',
     'lib/src/fasta/builder',
     'lib/src/fasta/dill',
     'lib/src/fasta/kernel',
     'lib/src/fasta/parser',
     'lib/src/fasta/scanner',
@@ skipping 60 matching lines @@
     'lib/src',
     'lib/src/base',
     'lib/src/fasta',
     'lib/src/fasta/kernel',
   ]),
   'lib/src/fasta/util': new SubpackageRules(),
   'lib/src/incremental': new SubpackageRules(allowedDependencies: [
     'lib',
     'lib/src',
     'lib/src/base',
+    'lib/src/byte_store',
     'lib/src/fasta',
     'lib/src/fasta/dill',
     'lib/src/fasta/kernel',
     'lib/src/fasta/parser',
     'lib/src/fasta/scanner',
     'lib/src/fasta/source',
   ]),
   'lib/src/scanner': new SubpackageRules(allowedDependencies: [
     'lib/src/base',
     // For error codes.
@@ skipping 165 matching lines @@
       if (subpackageRules[subpackage].allowSubdirs) {
         subpackageRules[subpackage].actuallyHasSubdirs = true;
       } else {
         problem('Uri $src is in a subfolder of $subpackage, but that '
             'subpackage does not allow dart files in subdirectories.');
       }
     }
     return subpackage;
   }
 }