Move byte_store.dart and file_byte_store.dart to their own subdirectory.

pkg/front_end/test/subpackage_relationships_test.dart

Index: pkg/front_end/test/subpackage_relationships_test.dart
diff --git a/pkg/front_end/test/subpackage_relationships_test.dart b/pkg/front_end/test/subpackage_relationships_test.dart
index abd8e2aa62e2178db6e5631ad346c542c72bc506..c78dd82147da583d4252e5c4ea156b98707d10b6 100644
--- a/pkg/front_end/test/subpackage_relationships_test.dart
+++ b/pkg/front_end/test/subpackage_relationships_test.dart
@@ -41,8 +41,8 @@ final subpackageRules = {
   'lib': new SubpackageRules(allowedDependencies: [
     'lib/src',
     'lib/src/base',
+    'lib/src/byte_store',
     'lib/src/fasta',
-    'lib/src/incremental',
   ]),
   'lib/src': new SubpackageRules(allowedDependencies: [
     'lib',
@@ -56,10 +56,11 @@ final subpackageRules = {
   'lib/src/base': new SubpackageRules(allowedDependencies: [
     'lib',
     'lib/src',
+    'lib/src/byte_store',
     'lib/src/fasta',
     'lib/src/fasta/util',
-    'lib/src/incremental'
   ]),
+  'lib/src/byte_store': new SubpackageRules(allowedDependencies: []),

[Siggi Cherem (dart-lang), 2017/08/07 17:44:05]

let's add a comment here to say that this folder should never have a dep to
lib/src/fasta/?

(I find some dependencies are OK to add, some are a sign that we are doing
something wrong, a comment will help that adding a dep to fasta is something
wrong)

[Paul Berry, 2017/08/07 17:48:03]

Done.

[ahe, 2017/08/08 14:00:00]

But that's not what Paul said was the intent of this CL. For this library to
become its own package, it shouldn't depend on other parts of front_end. What am
I missing?

   'lib/src/codegen': new SubpackageRules(),
   'lib/src/fasta': new SubpackageRules(allowedDependencies: [
     'lib',
@@ -140,6 +141,7 @@ final subpackageRules = {
     'lib',
     'lib/src',
     'lib/src/base',
+    'lib/src/byte_store',
     'lib/src/fasta',
     'lib/src/fasta/dill',
     'lib/src/fasta/kernel',