Revert "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, o…

Revert "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, or later through Observatory."

This reverts commit cc08f2ddd87d7a5c692b48b2e8dd629addf4d827.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/eddc456f296d626ef2b52e16fa80cbc827f7bfd1

[Dmitry Stefantsov, 2017-08-02 09:11:05]

dmitryas@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-08-02 09:29:33]

lgtm

[Dmitry Stefantsov, 2017-08-02 09:30:24]

Description was changed from

==========
Revert "[vm] Don't enable the profiler by default. Enable the profiler at
startup with --observe, or later through Observatory."

This reverts commit cc08f2ddd87d7a5c692b48b2e8dd629addf4d827.
==========

to

==========
Revert "[vm] Don't enable the profiler by default. Enable the profiler at
startup with --observe, or later through Observatory."

This reverts commit cc08f2ddd87d7a5c692b48b2e8dd629addf4d827.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eddc456f296d626ef2b52e16fa80cbc827f7bfd1
==========

[Dmitry Stefantsov, 2017-08-02 09:30:27]

Committed patchset #1 (id:1) manually as
eddc456f296d626ef2b52e16fa80cbc827f7bfd1 (presubmit successful).

[rmacnak, 2017-08-02 18:01:26]

On 2017/08/02 09:30:27, Dmitry Stefantsov wrote:
> Committed patchset #1 (id:1) manually as
> eddc456f296d626ef2b52e16fa80cbc827f7bfd1 (presubmit successful).

For posterity, the failure was

FAILED: none-vm debug_x64 vm/cc/Service_PersistentHandles
Expected: Pass 
Actual: Crash
CommandOutput[run_vm_unittest]:

stdout:
Running test: Service_PersistentHandles


stderr:
e:\b\build\slave\vm-win-debug-x64-be\build\sdk\runtime\vm\lockers.h: 50: error:
expected: mutex != NULL
Dumping native stack trace for thread 1a64
e:\b\build\slave\vm-win-debug-x64-be\build\sdk\runtime\vm\lockers.h: 50: error:
expected: mutex != NULL
Aborting re-entrant request for stack trace.


Command[run_vm_unittest]: set DART_CONFIGURATION=DebugX64 &
out\DebugX64\run_vm_tests --ignore-unrecognized-flags Service_PersistentHandles
Took 0:00:00.069007

Short reproduction command (experimental):
    python tools/test.py vm/cc/Service_PersistentHandles



===
=== 1 test failed
===