Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart

Issue 2990173002: Revert "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, o… (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart b/runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart
index 226ee35608b73f47e8993003fa47b1f6a618700e..2cfebceda7e934d354d92a5445e2bdbe7a9d38b7 100644
--- a/runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart
@@ -12,8 +12,6 @@ import '../mocks.dart';
main() {
SampleBufferControlElement.tag.ensureRegistration();
- const vm = const VMMock();
-
group('instantiation', () {
SampleProfileLoadingProgressMock progress;
StreamController<SampleProfileLoadingProgressEventMock> events;
@@ -22,7 +20,7 @@ main() {
events = new StreamController<SampleProfileLoadingProgressEventMock>();
});
test('no additional parameters', () {
- final e = new SampleBufferControlElement(vm, progress, events.stream);
+ final e = new SampleBufferControlElement(progress, events.stream);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.progress, equals(progress));
expect(e.selectedTag, equals(M.SampleProfileTag.none));
@@ -30,7 +28,7 @@ main() {
});
test('selected tag', () {
const tag = M.SampleProfileTag.userOnly;
- final e = new SampleBufferControlElement(vm, progress, events.stream,
+ final e = new SampleBufferControlElement(progress, events.stream,
selectedTag: tag);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.progress, equals(progress));
@@ -38,7 +36,7 @@ main() {
expect(e.showTag, isTrue);
});
test('show tag (true)', () {
- final e = new SampleBufferControlElement(vm, progress, events.stream,
+ final e = new SampleBufferControlElement(progress, events.stream,
showTag: true);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.progress, equals(progress));
@@ -46,7 +44,7 @@ main() {
expect(e.showTag, isTrue);
});
test('show tag (false)', () {
- final e = new SampleBufferControlElement(vm, progress, events.stream,
+ final e = new SampleBufferControlElement(progress, events.stream,
showTag: false);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.progress, equals(progress));
@@ -62,7 +60,7 @@ main() {
events = new StreamController<SampleProfileLoadingProgressEventMock>();
});
test('created after attachment', () async {
- final e = new SampleBufferControlElement(vm, progress, events.stream);
+ final e = new SampleBufferControlElement(progress, events.stream);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');
@@ -71,7 +69,7 @@ main() {
expect(e.children.length, isZero, reason: 'is empty');
});
test('listen for status changes', () async {
- final e = new SampleBufferControlElement(vm, progress, events.stream);
+ final e = new SampleBufferControlElement(progress, events.stream);
expect(events.hasListener, isFalse);
document.body.append(e);
await e.onRendered.first;
@@ -83,7 +81,7 @@ main() {
await e.onRendered.first;
});
test('follow updates changes', () async {
- final e = new SampleBufferControlElement(vm, progress, events.stream);
+ final e = new SampleBufferControlElement(progress, events.stream);
document.body.append(e);
await e.onRendered.first;
expect(e.querySelector('select'), isNull);
@@ -108,7 +106,7 @@ main() {
await e.onRendered.first;
});
test('follow updates changes (no tag)', () async {
- final e = new SampleBufferControlElement(vm, progress, events.stream,
+ final e = new SampleBufferControlElement(progress, events.stream,
showTag: false);
document.body.append(e);
await e.onRendered.first;
@@ -141,7 +139,7 @@ main() {
events = new StreamController<SampleProfileLoadingProgressEventMock>();
});
test('onModeChange', () async {
- final e = new SampleBufferControlElement(vm, progress, events.stream);
+ final e = new SampleBufferControlElement(progress, events.stream);
document.body.append(e);
await e.onRendered.first;
events.add(new SampleProfileLoadingProgressEventMock(
« no previous file with comments | « runtime/observatory/tests/observatory_ui/mocks/objects/vm.dart ('k') | runtime/observatory/tests/service/service.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698