Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Side by Side Diff: runtime/observatory/tests/service/test_helper.dart

Issue 2990173002: Revert "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, o… (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/service.status ('k') | runtime/vm/dart.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_helper; 5 library test_helper;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:io'; 9 import 'dart:io';
10 import 'package:observatory/service_io.dart'; 10 import 'package:observatory/service_io.dart';
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 var fullArgs = []; 127 var fullArgs = [];
128 if (pause_on_start) { 128 if (pause_on_start) {
129 fullArgs.add('--pause-isolates-on-start'); 129 fullArgs.add('--pause-isolates-on-start');
130 } 130 }
131 if (pause_on_exit) { 131 if (pause_on_exit) {
132 fullArgs.add('--pause-isolates-on-exit'); 132 fullArgs.add('--pause-isolates-on-exit');
133 } 133 }
134 if (pause_on_unhandled_exceptions) { 134 if (pause_on_unhandled_exceptions) {
135 fullArgs.add('--pause-isolates-on-unhandled-exceptions'); 135 fullArgs.add('--pause-isolates-on-unhandled-exceptions');
136 } 136 }
137 fullArgs.add('--profiler');
138 if (extraArgs != null) { 137 if (extraArgs != null) {
139 fullArgs.addAll(extraArgs); 138 fullArgs.addAll(extraArgs);
140 } 139 }
141 140
142 fullArgs.addAll(Platform.executableArguments); 141 fullArgs.addAll(Platform.executableArguments);
143 if (!testeeControlsServer) { 142 if (!testeeControlsServer) {
144 fullArgs.add('--enable-vm-service:0'); 143 fullArgs.add('--enable-vm-service:0');
145 } 144 }
146 fullArgs.addAll(args); 145 fullArgs.addAll(args);
147 146
(...skipping 16 matching lines...) Expand all
164 if (pause_on_start) { 163 if (pause_on_start) {
165 dartFlags.add('--pause_isolates_on_start'); 164 dartFlags.add('--pause_isolates_on_start');
166 fullArgs.add('--start-paused'); 165 fullArgs.add('--start-paused');
167 } 166 }
168 if (pause_on_exit) { 167 if (pause_on_exit) {
169 dartFlags.add('--pause_isolates_on_exit'); 168 dartFlags.add('--pause_isolates_on_exit');
170 } 169 }
171 if (pause_on_unhandled_exceptions) { 170 if (pause_on_unhandled_exceptions) {
172 dartFlags.add('--pause_isolates_on_unhandled_exceptions'); 171 dartFlags.add('--pause_isolates_on_unhandled_exceptions');
173 } 172 }
174 dartFlags.add('--profiler');
175 // Override mirrors. 173 // Override mirrors.
176 dartFlags.add('--enable_mirrors=true'); 174 dartFlags.add('--enable_mirrors=true');
177 if (extraArgs != null) { 175 if (extraArgs != null) {
178 fullArgs.addAll(extraArgs); 176 fullArgs.addAll(extraArgs);
179 } 177 }
180 178
181 fullArgs.addAll(Platform.executableArguments); 179 fullArgs.addAll(Platform.executableArguments);
182 if (!testeeControlsServer) { 180 if (!testeeControlsServer) {
183 fullArgs.add('--observatory-port=0'); 181 fullArgs.add('--observatory-port=0');
184 } 182 }
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 new _ServiceTesterRunner().run( 479 new _ServiceTesterRunner().run(
482 mainArgs: mainArgs, 480 mainArgs: mainArgs,
483 extraArgs: extraArgs, 481 extraArgs: extraArgs,
484 vmTests: tests, 482 vmTests: tests,
485 pause_on_start: pause_on_start, 483 pause_on_start: pause_on_start,
486 pause_on_exit: pause_on_exit, 484 pause_on_exit: pause_on_exit,
487 verbose_vm: verbose_vm, 485 verbose_vm: verbose_vm,
488 pause_on_unhandled_exceptions: pause_on_unhandled_exceptions); 486 pause_on_unhandled_exceptions: pause_on_unhandled_exceptions);
489 } 487 }
490 } 488 }
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/service.status ('k') | runtime/vm/dart.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698