Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 298863002: Fix undefined behavior in DirectWrite GDI compatible metrics. (Closed)

Created:
6 years, 7 months ago by bungeman-skia
Modified:
6 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix undefined behavior in DirectWrite GDI compatible metrics. GetGdiCompatibleGlyphMetrics checks the matrix passed to it. If the matrix has any NaNs or INFs or otherwise looks bad, it returns E_INVALIDARG and so the advances will be zero. BUG=skia:2579 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=14829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/ports/SkFontHost_win_dw.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/win/SkHRESULT.cpp View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
The changes to SkTraceHR were done because we actually always want to log when SkTraceHR ...
6 years, 7 months ago (2014-05-21 17:27:23 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-21 17:59:39 UTC) #2
bungeman-skia
6 years, 7 months ago (2014-05-21 19:44:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698