Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/utils/win/SkHRESULT.cpp

Issue 298863002: Fix undefined behavior in DirectWrite GDI compatible metrics. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ports/SkFontHost_win_dw.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkTypes.h" 8 #include "SkTypes.h"
9 9
10 #include "SkHRESULT.h" 10 #include "SkHRESULT.h"
11 11
12 void SkTraceHR(const char* file, unsigned long line, 12 void SkTraceHR(const char* file, unsigned long line, HRESULT hr, const char* msg ) {
13 HRESULT hr, const char* msg) { 13 if (NULL != msg) {
14 SkDEBUGCODE(if (NULL != msg) SkDEBUGF(("%s\n", msg))); 14 SkDebugf("%s\n", msg);
15 SkDEBUGF(("%s(%lu) : error 0x%x: ", file, line, hr)); 15 }
16 SkDebugf("%s(%lu) : error 0x%x: ", file, line, hr);
16 17
17 LPSTR errorText = NULL; 18 LPSTR errorText = NULL;
18 FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | 19 FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER |
19 FORMAT_MESSAGE_FROM_SYSTEM | 20 FORMAT_MESSAGE_FROM_SYSTEM |
20 FORMAT_MESSAGE_IGNORE_INSERTS, 21 FORMAT_MESSAGE_IGNORE_INSERTS,
21 NULL, 22 NULL,
22 hr, 23 hr,
23 MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), 24 MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
24 (LPSTR) &errorText, 25 (LPSTR) &errorText,
25 0, 26 0,
26 NULL 27 NULL
27 ); 28 );
28 29
29 if (NULL == errorText) { 30 if (NULL == errorText) {
30 SkDEBUGF(("<unknown>\n")); 31 SkDebugf("<unknown>\n");
31 } else { 32 } else {
32 SkDEBUGF(("%s", errorText)); 33 SkDebugf("%s", errorText);
33 LocalFree(errorText); 34 LocalFree(errorText);
34 errorText = NULL; 35 errorText = NULL;
35 } 36 }
36 } 37 }
OLDNEW
« no previous file with comments | « src/ports/SkFontHost_win_dw.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698