src/ports/SkFontHost_win_dw.cpp - Issue 298863002: Fix undefined behavior in DirectWrite GDI compatible metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_win_dw.cpp

Issue 298863002: Fix undefined behavior in DirectWrite GDI compatible metrics. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_win_dw.cpp

===================================================================

--- src/ports/SkFontHost_win_dw.cpp (revision 14827)

+++ src/ports/SkFontHost_win_dw.cpp (working copy)

@@ -801,6 +801,8 @@

fGsA.m12 = SkScalarToFloat(GsA.get(SkMatrix::kMSkewY)); // This should be ~0.

fGsA.m21 = SkScalarToFloat(GsA.get(SkMatrix::kMSkewX));

fGsA.m22 = SkScalarToFloat(GsA.get(SkMatrix::kMScaleY));

+ fGsA.dx = 0;

+ fGsA.dy = 0;

// fG_inv is G inverse, which is fairly simple since G is 2x2 rotational.

fG_inv.setAll(G.get(SkMatrix::kMScaleX), -G.get(SkMatrix::kMSkewX), G.get(SkMatrix::kMTransX),

« no previous file with comments | « no previous file | src/utils/win/SkHRESULT.cpp » ('j') | no next file with comments »