Link all the necessary default options into TSan v2 binaries.

Link all the necessary default options into TSan v2 binaries.

BUG=302040
TBR=earthdok@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272021

[Alexander Potapenko, 2014-05-21 10:04:05]

TBR

[Alexander Potapenko, 2014-05-21 10:04:07]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-05-21 10:04:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/298853002/1

[earthdok, 2014-05-21 12:03:07]

https://codereview.chromium.org/298853002/diff/1/base/debug/sanitizer_options.cc
File base/debug/sanitizer_options.cc (right):

https://codereview.chromium.org/298853002/diff/1/base/debug/sanitizer_options...
base/debug/sanitizer_options.cc:90:
"third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer ";
If current dir != source root, this will break *even* if symbolizer is in PATH.

Perhaps this calls for a fix on the sanitizer side (i.e. fall back to PATH if
the explicitly specified symbolizer is not found). I'm not so sure though, I
think it makes more sense for an explicitly specified binary to override all
other methods of symbolizer discovery.

[commit-bot: I haz the power, 2014-05-21 23:51:38]

Change committed as 272021

[Alexander Potapenko, 2014-05-22 06:51:29]

On 2014/05/21 12:03:07, earthdok wrote:
>
https://codereview.chromium.org/298853002/diff/1/base/debug/sanitizer_options.cc
> File base/debug/sanitizer_options.cc (right):
> 
>
https://codereview.chromium.org/298853002/diff/1/base/debug/sanitizer_options...
> base/debug/sanitizer_options.cc:90:
> "third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer ";
> If current dir != source root, this will break *even* if symbolizer is in
PATH.
> 
> Perhaps this calls for a fix on the sanitizer side (i.e. fall back to PATH if
> the explicitly specified symbolizer is not found). I'm not so sure though, I
> think it makes more sense for an explicitly specified binary to override all
> other methods of symbolizer discovery.

Per the offline discussion, we want TSan to Just Work for inexperienced users.
Power users can still override the default options.
I agree that a fallback to PATH is nice to have.

[sadrul, 2014-05-22 14:30:17]

Hi. Looks like this has been causing build failures in this bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20(T...

Mind taking a look? Or should I go ahead with a revert for now?

[Alexander Potapenko, 2014-05-22 14:43:39]

Fix is in CQ: https://codereview.chromium.org/296513014

On Thu, May 22, 2014 at 7:30 AM,  <sadrul@chromium.org> wrote:
> Hi. Looks like this has been causing build failures in this bot:
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20(T...
>
> Mind taking a look? Or should I go ahead with a revert for now?
>
> https://codereview.chromium.org/298853002/



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sadrul, 2014-05-22 14:45:23]

On 2014/05/22 14:43:39, Alexander Potapenko wrote:
> Fix is in CQ: https://codereview.chromium.org/296513014

Sweet! thanks