Link all the necessary default options into TSan v2 binaries.

base/debug/sanitizer_options.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the default options for various compiler-based dynamic
 // tools.
 
 #include "build/build_config.h"
 
 // Functions returning default options are declared weak in the tools' runtime
@@ skipping 57 matching lines @@
 const char *__asan_default_options() {
   return kAsanDefaultOptions;
 }
 #endif  // OS_LINUX || OS_MACOSX
 #endif  // ADDRESS_SANITIZER
 
 #if defined(THREAD_SANITIZER) && defined(OS_LINUX)
 // Default options for ThreadSanitizer in various configurations:
 //   detect_deadlocks=1 - enable deadlock (lock inversion) detection.
 //   second_deadlock_stack=1 - more verbose deadlock reports.
-const char kTsanDefaultOptions[] = "detect_deadlocks=1 second_deadlock_stack=1";
+//   report_signal_unsafe=0 - do not report async-signal-unsafe functions
+//     called from signal handlers.
+//   report_thread_leaks=0 - do not report unjoined threads at the end of
+//     the program execution.
+//   print_suppressions=1 - print the list of matched suppressions.
+//   suppressions=<path> - path to the suppressions file.
+//   external_symbolizer_path=<path> - path to the llvm-symbolizer binary.
+const char kTsanDefaultOptions[] =
+    "detect_deadlocks=1 second_deadlock_stack=1 report_signal_unsafe=0 "
+    "report_thread_leaks=0 print_suppressions=1 "
+    "suppressions=tools/valgrind/tsan_v2/suppressions.txt "
+    "external_symbolizer_path="
+    "third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer ";

[earthdok, 2014/05/21 12:03:07]

If current dir != source root, this will break *even* if symbolizer is in PATH.

Perhaps this calls for a fix on the sanitizer side (i.e. fall back to PATH if
the explicitly specified symbolizer is not found). I'm not so sure though, I
think it makes more sense for an explicitly specified binary to override all
other methods of symbolizer discovery.

 
 extern "C"
 __attribute__((no_sanitize_thread))
 __attribute__((visibility("default")))
 // The function isn't referenced from the executable itself. Make sure it isn't
 // stripped by the linker.
 __attribute__((used))
 const char *__tsan_default_options() {
   return kTsanDefaultOptions;
 }
 
 #endif  // THREAD_SANITIZER && OS_LINUX