Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 296513014: Do not set the default `suppressions` and `external_symbolizer_path` options for TSan. (Closed)

Created:
6 years, 7 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
Reviewers:
earthdok
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Do not set the default `suppressions` and `external_symbolizer_path` options for TSan. This broke TSan compilation, as the tool dies when attempting to open a non-existent file. BUG=302040 TBR=earthdok@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M base/debug/sanitizer_options.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
TBR
6 years, 7 months ago (2014-05-22 11:59:22 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-22 11:59:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/296513014/1
6 years, 7 months ago (2014-05-22 12:01:15 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 19:09:38 UTC) #4
Message was sent while issue was closed.
Change committed as 272262

Powered by Google App Engine
This is Rietveld 408576698