Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2987953002: Milo: Show accurate pending build numbers for builder view. (Closed)

Created:
3 years, 4 months ago by Ryan Tseng
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh., nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Show accurate pending build numbers for builder view. We were not showing the correct numbers, since the master doesn't send all of its pending builds to milo, just 25. But it does send the total number, which we wern't displaying. BUG= Review-Url: https://codereview.chromium.org/2987953002 Committed: https://github.com/luci/luci-go/commit/b1e3f58580b05bbba4a8d821ee2e0dd79efde34d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M milo/api/resp/builder.go View 1 chunk +6 lines, -3 lines 0 comments Download
M milo/buildsource/buildbot/builder.go View 1 chunk +1 line, -0 lines 0 comments Download
M milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json View 1 chunk +1 line, -0 lines 0 comments Download
M milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json View 1 chunk +1 line, -0 lines 0 comments Download
M milo/frontend/appengine/templates/pages/builder.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Ryan Tseng
ptal anyone demo: https://screenshot.googleplex.com/fvjfrVEsHwJ
3 years, 4 months ago (2017-07-26 20:27:15 UTC) #4
Vadim Sh.
lgtm
3 years, 4 months ago (2017-07-26 21:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2987953002/1
3 years, 4 months ago (2017-07-26 21:25:52 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-07-26 21:31:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/b1e3f58580b05bbba4a8d821ee2e0dd79efde34d

Powered by Google App Engine
This is Rietveld 408576698