milo/buildsource/buildbot/builder.go - Issue 2987953002: Milo: Show accurate pending build numbers for builder view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/buildsource/buildbot/builder.go

Issue 2987953002: Milo: Show accurate pending build numbers for builder view. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/buildsource/buildbot/builder.go

diff --git a/milo/buildsource/buildbot/builder.go b/milo/buildsource/buildbot/builder.go

index 96fb8b82c139b03858f32cfc643b95c72b1747a1..47ad0de1631d5317af72df6a4455d5ae4d031a65 100644

--- a/milo/buildsource/buildbot/builder.go

+++ b/milo/buildsource/buildbot/builder.go

@@ -238,6 +238,7 @@ func builderImpl(

}

// Extract pending builds out of the master json.

result.PendingBuilds = make([]*resp.BuildSummary, len(p.PendingBuildStates))

+ result.PendingBuildNum = p.PendingBuilds

logging.Debugf(c, "Number of pending builds: %d", len(p.PendingBuildStates))

for i, pb := range p.PendingBuildStates {

start := time.Unix(int64(pb.SubmittedAt), 0).UTC()