Revert of Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

Revert of Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (patchset #28 id:540001 of https://codereview.chromium.org/2946113002/ )

Reason for revert:
This CL has caused crashes reported in https://crbug.com/747403

Original issue's description:
> Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.
> 
> FrameIsAd heuristics
> ====================
> 
> After this CL, TopDocumentIsolation will by default only isolate
> cross-site frames that also match FrameIsAd heuristics.  This behavior
> is controllable via Finch, via chrome://flags and via command line
> (see below for details).
> 
> Impact on browser tests
> =======================
> 
> Browser tests should not depend on the FrameIsAd heuristics.  This is
> taken care of by EnableTopDocumentIsolationForTesting, which enables
> the mode that isolates all frames that are cross-site from the main
> frame.
> 
> chrome://flags changes
> ======================
> 
> This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the
> following variations are present (3. and 4. are introduced by this CL):
> 1. Default
> 2. Enabled
> 3. Enabled (CrossSite - isolate all frames from sites other than
>             the top-level frame)
> 4. Enabled (Ads - isolate only cross-site ads detected by heuristics)
> 5. Disabled
> 
> Today variations 1 and 5 turn off TDI mode (because the default for
> kTopDocumentIsolation base::Feature is to be disabled).  Variation 3
> enables TDI and isolates all cross-site frames (this is what browser
> tests use when enabling TDI via EnableTopDocumentIsolationForTesting).
> Variations 2 and 4 enable TDI and use FrameIsAd heuristics.  Probably a
> better name for variation 2 would be "Enabled (unspecified isolation
> mode)", but the "Enabled" string is hardcoded in the chrome://flags
> code.
> 
> I've manually tested that if a user enabled TDI in chrome://flags before
> this CL, then it will stay enabled after this CL (variation 2).
> 
> Command line
> ============
> 
> After this CL, the user can control TDI with the following command line
> switches:
> 
> - When no extra cmdline switches are present, then TDI is controlled via
>   chrome://flags and/or Finch experiments.
> 
> - Cmdline flags to disable TDI:
>   --disable-features=top-document-isolation
> 
> - Cmdline flags to enable TDI using unspecified / default isolation mode:
>   --enable-features=top-document-isolation
> 
> - Cmdline flags to enable TDI using specific isolation mode (1 for
>   cross-site, 2 for ads;  see the TopDocumentIsolationMode enum for all
>   possible values):
>   --enable-features="top-document-isolation<TopDocumentIsolation" \
>   --force-fieldtrials=TopDocumentIsolation/Cmdline \
>   --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1
> 
> BUG=733303
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2946113002
> Cr-Commit-Position: refs/heads/master@{#488372}
> Committed: https://chromium.googlesource.com/chromium/src/+/c1dd61f01ced0c94ccc2efe373a93c696bb98c2f

TBR=creis@chromium.org,jam@chromium.org,asvitkine@chromium.org,jkarlin@chromium.org,csharrison@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=733303
Review-Url: https://codereview.chromium.org/2987563004
Cr-Commit-Position: refs/heads/master@{#488660}
Committed: https://chromium.googlesource.com/chromium/src/+/9d5eaef0eb860f65218f56e73af5aeb5408e3848

[Łukasz Anforowicz, 2017-07-21 15:25:45]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-07-21 15:25:45]

Created Revert of Use FrameIsAd to decide whether to isolate a frame in
TopDocumentIsolation mode.

[commit-bot: I haz the power, 2017-07-21 15:25:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-21 15:26:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1500650745505400, "parent_rev":
"1716669361d966178f6b2bb419981de83b1643c6", "commit_rev":
"9d5eaef0eb860f65218f56e73af5aeb5408e3848"}

[commit-bot: I haz the power, 2017-07-21 15:26:47]

Description was changed from

==========
Revert of Use FrameIsAd to decide whether to isolate a frame in
TopDocumentIsolation mode. (patchset #28 id:540001 of
https://codereview.chromium.org/2946113002/ )

Reason for revert:
This CL has caused crashes reported in https://crbug.com/747403

Original issue's description:
> Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation
mode.
> 
> FrameIsAd heuristics
> ====================
> 
> After this CL, TopDocumentIsolation will by default only isolate
> cross-site frames that also match FrameIsAd heuristics.  This behavior
> is controllable via Finch, via chrome://flags and via command line
> (see below for details).
> 
> Impact on browser tests
> =======================
> 
> Browser tests should not depend on the FrameIsAd heuristics.  This is
> taken care of by EnableTopDocumentIsolationForTesting, which enables
> the mode that isolates all frames that are cross-site from the main
> frame.
> 
> chrome://flags changes
> ======================
> 
> This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the
> following variations are present (3. and 4. are introduced by this CL):
> 1. Default
> 2. Enabled
> 3. Enabled (CrossSite - isolate all frames from sites other than
>             the top-level frame)
> 4. Enabled (Ads - isolate only cross-site ads detected by heuristics)
> 5. Disabled
> 
> Today variations 1 and 5 turn off TDI mode (because the default for
> kTopDocumentIsolation base::Feature is to be disabled).  Variation 3
> enables TDI and isolates all cross-site frames (this is what browser
> tests use when enabling TDI via EnableTopDocumentIsolationForTesting).
> Variations 2 and 4 enable TDI and use FrameIsAd heuristics.  Probably a
> better name for variation 2 would be "Enabled (unspecified isolation
> mode)", but the "Enabled" string is hardcoded in the chrome://flags
> code.
> 
> I've manually tested that if a user enabled TDI in chrome://flags before
> this CL, then it will stay enabled after this CL (variation 2).
> 
> Command line
> ============
> 
> After this CL, the user can control TDI with the following command line
> switches:
> 
> - When no extra cmdline switches are present, then TDI is controlled via
>   chrome://flags and/or Finch experiments.
> 
> - Cmdline flags to disable TDI:
>   --disable-features=top-document-isolation
> 
> - Cmdline flags to enable TDI using unspecified / default isolation mode:
>   --enable-features=top-document-isolation
> 
> - Cmdline flags to enable TDI using specific isolation mode (1 for
>   cross-site, 2 for ads;  see the TopDocumentIsolationMode enum for all
>   possible values):
>   --enable-features="top-document-isolation<TopDocumentIsolation" \
>   --force-fieldtrials=TopDocumentIsolation/Cmdline \
>   --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1
> 
> BUG=733303
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2946113002
> Cr-Commit-Position: refs/heads/master@{#488372}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c1dd61f01ced0c94ccc2efe373a9...

TBR=creis@chromium.org,jam@chromium.org,asvitkine@chromium.org,jkarlin@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=733303
==========

to

==========
Revert of Use FrameIsAd to decide whether to isolate a frame in
TopDocumentIsolation mode. (patchset #28 id:540001 of
https://codereview.chromium.org/2946113002/ )

Reason for revert:
This CL has caused crashes reported in https://crbug.com/747403

Original issue's description:
> Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation
mode.
> 
> FrameIsAd heuristics
> ====================
> 
> After this CL, TopDocumentIsolation will by default only isolate
> cross-site frames that also match FrameIsAd heuristics.  This behavior
> is controllable via Finch, via chrome://flags and via command line
> (see below for details).
> 
> Impact on browser tests
> =======================
> 
> Browser tests should not depend on the FrameIsAd heuristics.  This is
> taken care of by EnableTopDocumentIsolationForTesting, which enables
> the mode that isolates all frames that are cross-site from the main
> frame.
> 
> chrome://flags changes
> ======================
> 
> This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the
> following variations are present (3. and 4. are introduced by this CL):
> 1. Default
> 2. Enabled
> 3. Enabled (CrossSite - isolate all frames from sites other than
>             the top-level frame)
> 4. Enabled (Ads - isolate only cross-site ads detected by heuristics)
> 5. Disabled
> 
> Today variations 1 and 5 turn off TDI mode (because the default for
> kTopDocumentIsolation base::Feature is to be disabled).  Variation 3
> enables TDI and isolates all cross-site frames (this is what browser
> tests use when enabling TDI via EnableTopDocumentIsolationForTesting).
> Variations 2 and 4 enable TDI and use FrameIsAd heuristics.  Probably a
> better name for variation 2 would be "Enabled (unspecified isolation
> mode)", but the "Enabled" string is hardcoded in the chrome://flags
> code.
> 
> I've manually tested that if a user enabled TDI in chrome://flags before
> this CL, then it will stay enabled after this CL (variation 2).
> 
> Command line
> ============
> 
> After this CL, the user can control TDI with the following command line
> switches:
> 
> - When no extra cmdline switches are present, then TDI is controlled via
>   chrome://flags and/or Finch experiments.
> 
> - Cmdline flags to disable TDI:
>   --disable-features=top-document-isolation
> 
> - Cmdline flags to enable TDI using unspecified / default isolation mode:
>   --enable-features=top-document-isolation
> 
> - Cmdline flags to enable TDI using specific isolation mode (1 for
>   cross-site, 2 for ads;  see the TopDocumentIsolationMode enum for all
>   possible values):
>   --enable-features="top-document-isolation<TopDocumentIsolation" \
>   --force-fieldtrials=TopDocumentIsolation/Cmdline \
>   --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1
> 
> BUG=733303
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2946113002
> Cr-Commit-Position: refs/heads/master@{#488372}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c1dd61f01ced0c94ccc2efe373a9...

TBR=creis@chromium.org,jam@chromium.org,asvitkine@chromium.org,jkarlin@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=733303

Review-Url: https://codereview.chromium.org/2987563004
Cr-Commit-Position: refs/heads/master@{#488660}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d5eaef0eb860f65218f56e73af5...
==========

[commit-bot: I haz the power, 2017-07-21 15:26:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d5eaef0eb860f65218f56e73af5...