Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: chrome/browser/about_flags.cc

Issue 2987563004: Revert of Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 63f3b45a429f4ee72e1e5d6bb217c0c690fe77b6..ef5f554a0a6ea352619117d67d440d82b40aa05f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1101,20 +1101,6 @@
cc::switches::kEnableCheckerImaging, ""},
{flags_ui::kGenericExperimentChoiceDisabled,
cc::switches::kDisableCheckerImaging, ""},
-};
-
-#define DEFINE_TDI_MODE_FEATURE_PARAM(name, value, description) \
- const FeatureEntry::FeatureParam kTopDocumentIsolationVariations_##name[] = \
- {{features::kTopDocumentIsolationModeParam, #value}};
-FOR_EACH_TDI_MODE(DEFINE_TDI_MODE_FEATURE_PARAM)
-#undef DEFINE_TDI_MODE_FEATURE_PARAM
-
-const FeatureEntry::FeatureVariation kTopDocumentIsolationVariations[] = {
-#define DEFINE_TDI_MODE_VARIATION(name, value, description) \
- {"(" #name " - " description ")", kTopDocumentIsolationVariations_##name, \
- arraysize(kTopDocumentIsolationVariations_##name), nullptr},
- FOR_EACH_TDI_MODE(DEFINE_TDI_MODE_VARIATION)
-#undef DEFINE_TDI_MODE_VARIATION
};
// RECORDING USER METRICS FOR FLAGS:
@@ -1979,9 +1965,7 @@
{"enable-top-document-isolation",
flag_descriptions::kTopDocumentIsolationName,
flag_descriptions::kTopDocumentIsolationDescription, kOsAll,
- FEATURE_WITH_PARAMS_VALUE_TYPE(features::kTopDocumentIsolation,
- kTopDocumentIsolationVariations,
- "TopDocumentIsolation")},
+ FEATURE_VALUE_TYPE(features::kTopDocumentIsolation)},
{"enable-use-zoom-for-dsf", flag_descriptions::kEnableUseZoomForDsfName,
flag_descriptions::kEnableUseZoomForDsfDescription, kOsAll,
MULTI_VALUE_TYPE(kEnableUseZoomForDSFChoices)},
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698