|
|
DescriptionAdd 64 bit system interceptors.
BUG=
Review-Url: https://codereview.chromium.org/2986273002
Committed: https://github.com/google/syzygy/commit/2675f17e8f271fe7c48ffc45a68aa6318011c30a
Patch Set 1 #Patch Set 2 : Add 64 bit system interceptors. #
Total comments: 1
Messages
Total messages: 21 (17 generated)
The CQ bit was checked by njanevsk@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_rel_try on master.tryserver.client.syzygy (JOB_FAILED, https://build.chromium.org/p/tryserver.client.syzygy/builders/win_x64_rel_try...)
The CQ bit was checked by njanevsk@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_rel_try on master.tryserver.client.syzygy (JOB_FAILED, https://build.chromium.org/p/tryserver.client.syzygy/builders/win_rel_try/bui...)
The CQ bit was checked by njanevsk@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add 64 bit system interceptors. BUG= ========== to ========== Add 64 bit system interceptors. BUG= ==========
njanevsk@google.com changed reviewers: + chrisha@chromium.org, sebmarchand@chromium.org
Added the method needed for compiling and linking the 64 bit version for the 64 bit integration tests. There is another CL: https://codereview.chromium.org/2990123002/ that contains update of the py script and the gyp file and depends on this CL. PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2986273002/diff/20001/syzygy/agent/asan/syste... File syzygy/agent/asan/system_interceptors_x64.def (right): https://codereview.chromium.org/2986273002/diff/20001/syzygy/agent/asan/syste... syzygy/agent/asan/system_interceptors_x64.def:33: __asan_init=asan_init Add a blank line to separate this from the previous block.
The CQ bit was checked by njanevsk@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501704158658460, "parent_rev": "ded3e13006dc2dacded62d04e2d68dde2cc2aa5b", "commit_rev": "2675f17e8f271fe7c48ffc45a68aa6318011c30a"}
Message was sent while issue was closed.
Description was changed from ========== Add 64 bit system interceptors. BUG= ========== to ========== Add 64 bit system interceptors. BUG= Review-Url: https://codereview.chromium.org/2986273002 Committed: https://github.com/google/syzygy/commit/2675f17e8f271fe7c48ffc45a68aa6318011c30a ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://github.com/google/syzygy/commit/2675f17e8f271fe7c48ffc45a68aa6318011c30a |