Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2990123002: Add flag to compile and link for 64 bit architecture.

Created:
3 years, 4 months ago by njanevsk
Modified:
3 years, 4 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Add flag to compile and link for 64 bit architecture. BUG=

Patch Set 1 : Add flag to compile and link for 64 bit architecture. #

Patch Set 2 : Add flag to compile and link for 64 bit architecture. #

Total comments: 2

Patch Set 3 : Add flag to compile and link for 64 bit architecture. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M syzygy/integration_tests/integration_tests.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M syzygy/integration_tests/make_integration_tests_clang.py View 1 2 8 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
njanevsk
Working on rebasing this but it is the code to compile and link 64bit.
3 years, 4 months ago (2017-08-11 20:30:11 UTC) #13
njanevsk
Working on rebasing this but it is the code to compile and link 64bit.
3 years, 4 months ago (2017-08-11 20:30:13 UTC) #14
Sébastien Marchand
https://codereview.chromium.org/2990123002/diff/60001/syzygy/integration_tests/make_integration_tests_clang.py File syzygy/integration_tests/make_integration_tests_clang.py (right): https://codereview.chromium.org/2990123002/diff/60001/syzygy/integration_tests/make_integration_tests_clang.py#newcode40 syzygy/integration_tests/make_integration_tests_clang.py:40: # By default set the bittness flag to 32 ...
3 years, 4 months ago (2017-08-11 20:51:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2990123002/80001
3 years, 4 months ago (2017-08-11 21:11:13 UTC) #17
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 21:11:15 UTC) #19
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-syzygy-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698