The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure.

The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure.

Relanding this with the browser test fixes.

Failure cases include, an invalid AppCacheHost instance, failure to create a request handler, etc.
We already notify the client about the latter case above. Need to do this for an invalid host as well.
This caused the w3schools AppCache test page to spin indefinitely if we pass in an invalid URL.

Additionally on the renderer side we need to reset the cached URLLoaderFactory pointer if a null factory
is passed in the CommitNavigation IPC. This ensures that the request hits the default network loader.

BUG=715632
TEST=Covered by browser test. AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation

This reverts commit a08d0fc015c42ce95a104c0f4e3de9448b7721e1.

Review-Url: https://codereview.chromium.org/2986043002
Cr-Commit-Position: refs/heads/master@{#490025}
Committed: https://chromium.googlesource.com/chromium/src/+/aad9e6266f96e08ae80b9af238a9e6121a28c76e

[ananta, 2017-07-27 18:41:27]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-27 18:41:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2017-07-27 18:42:21]

ananta@chromium.org changed reviewers:
+ jam@chromium.org, michaeln@chromium.org

[ananta, 2017-07-27 18:42:21]

The only change with the previous patch is a check in the test for the request
count. We now expect it to be greater than 1.

[commit-bot: I haz the power, 2017-07-27 19:02:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-27 19:02:08]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jam, 2017-07-27 21:41:35]

lgtm

[ananta, 2017-07-27 21:42:05]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-07-27 21:42:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 22:41:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501191725549890,
"parent_rev": "94d248f20319c705b7fda1f2074515c72b053485", "commit_rev":
"aad9e6266f96e08ae80b9af238a9e6121a28c76e"}

[commit-bot: I haz the power, 2017-07-27 22:42:09]

Description was changed from

==========
The Appcache subresource URL factory needs to inform the URLLoaderClient if
there is a failure.

Relanding this with the browser test fixes.

Failure cases include, an invalid AppCacheHost instance, failure to create a
request handler, etc.
We already notify the client about the latter case above. Need to do this for an
invalid host as well.
This caused the w3schools AppCache test page to spin indefinitely if we pass in
an invalid URL.

Additionally on the renderer side we need to reset the cached URLLoaderFactory
pointer if a null factory
is passed in the CommitNavigation IPC. This ensures that the request hits the
default network loader.

BUG=715632
TEST=Covered by browser test.
AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation

This reverts commit a08d0fc015c42ce95a104c0f4e3de9448b7721e1.
==========

to

==========
The Appcache subresource URL factory needs to inform the URLLoaderClient if
there is a failure.

Relanding this with the browser test fixes.

Failure cases include, an invalid AppCacheHost instance, failure to create a
request handler, etc.
We already notify the client about the latter case above. Need to do this for an
invalid host as well.
This caused the w3schools AppCache test page to spin indefinitely if we pass in
an invalid URL.

Additionally on the renderer side we need to reset the cached URLLoaderFactory
pointer if a null factory
is passed in the CommitNavigation IPC. This ensures that the request hits the
default network loader.

BUG=715632
TEST=Covered by browser test.
AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation

This reverts commit a08d0fc015c42ce95a104c0f4e3de9448b7721e1.

Review-Url: https://codereview.chromium.org/2986043002
Cr-Commit-Position: refs/heads/master@{#490025}
Committed:
https://chromium.googlesource.com/chromium/src/+/aad9e6266f96e08ae80b9af238a9...
==========

[commit-bot: I haz the power, 2017-07-27 22:42:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aad9e6266f96e08ae80b9af238a9...