Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: content/browser/appcache/appcache_subresource_url_factory.h

Issue 2986043002: The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. (Closed)
Patch Set: Change request count check to be greater than 1. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_SUBRESOURCE_URL_FACTORY_H_ 5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_SUBRESOURCE_URL_FACTORY_H_
6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_SUBRESOURCE_URL_FACTORY_H_ 6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_SUBRESOURCE_URL_FACTORY_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "content/common/content_export.h"
10 #include "content/public/common/url_loader_factory.mojom.h" 11 #include "content/public/common/url_loader_factory.mojom.h"
11 #include "mojo/public/cpp/bindings/binding.h" 12 #include "mojo/public/cpp/bindings/binding.h"
12 #include "net/traffic_annotation/network_traffic_annotation.h" 13 #include "net/traffic_annotation/network_traffic_annotation.h"
13 #include "url/gurl.h" 14 #include "url/gurl.h"
14 15
15 namespace content { 16 namespace content {
16 17
17 class AppCacheHost; 18 class AppCacheHost;
18 class AppCacheJob; 19 class AppCacheJob;
19 class AppCacheServiceImpl; 20 class AppCacheServiceImpl;
20 class URLLoaderFactoryGetter; 21 class URLLoaderFactoryGetter;
21 22
22 // Implements the URLLoaderFactory mojom for AppCache subresource requests. 23 // Implements the URLLoaderFactory mojom for AppCache subresource requests.
23 class AppCacheSubresourceURLFactory : public mojom::URLLoaderFactory { 24 class CONTENT_EXPORT AppCacheSubresourceURLFactory
25 : public mojom::URLLoaderFactory {
24 public: 26 public:
25 ~AppCacheSubresourceURLFactory() override; 27 ~AppCacheSubresourceURLFactory() override;
26 28
27 // Factory function to create an instance of the factory. 29 // Factory function to create an instance of the factory.
28 // 1. The |factory_getter| parameter is used to query the network service 30 // 1. The |factory_getter| parameter is used to query the network service
29 // to pass network requests to. 31 // to pass network requests to.
30 // 2. The |host| parameter contains the appcache host instance. This is used 32 // 2. The |host| parameter contains the appcache host instance. This is used
31 // to create the AppCacheRequestHandler instances for handling subresource 33 // to create the AppCacheRequestHandler instances for handling subresource
32 // requests. 34 // requests.
33 // Returns the AppCacheSubresourceURLFactory instance. The URLLoaderFactoryPtr 35 // Returns the AppCacheSubresourceURLFactory instance. The URLLoaderFactoryPtr
(...skipping 11 matching lines...) Expand all
45 const ResourceRequest& request, 47 const ResourceRequest& request,
46 mojom::URLLoaderClientPtr client, 48 mojom::URLLoaderClientPtr client,
47 const net::MutableNetworkTrafficAnnotationTag& 49 const net::MutableNetworkTrafficAnnotationTag&
48 traffic_annotation) override; 50 traffic_annotation) override;
49 void SyncLoad(int32_t routing_id, 51 void SyncLoad(int32_t routing_id,
50 int32_t request_id, 52 int32_t request_id,
51 const ResourceRequest& request, 53 const ResourceRequest& request,
52 SyncLoadCallback callback) override; 54 SyncLoadCallback callback) override;
53 55
54 private: 56 private:
57 friend class AppCacheNetworkServiceBrowserTest;
58
55 AppCacheSubresourceURLFactory(mojom::URLLoaderFactoryRequest request, 59 AppCacheSubresourceURLFactory(mojom::URLLoaderFactoryRequest request,
56 URLLoaderFactoryGetter* factory_getter, 60 URLLoaderFactoryGetter* factory_getter,
57 base::WeakPtr<AppCacheHost> host); 61 base::WeakPtr<AppCacheHost> host);
58 62
59 void OnConnectionError(); 63 void OnConnectionError();
60 64
65 // Notifies the |client| if there is a failure. The |error_code| contains the
66 // actual error.
67 void NotifyError(mojom::URLLoaderClientPtr client, int error_code);
68
61 // Mojo binding. 69 // Mojo binding.
62 mojo::Binding<mojom::URLLoaderFactory> binding_; 70 mojo::Binding<mojom::URLLoaderFactory> binding_;
63 71
64 // Used to retrieve the network service factory to pass unhandled requests to 72 // Used to retrieve the network service factory to pass unhandled requests to
65 // the network service. 73 // the network service.
66 scoped_refptr<URLLoaderFactoryGetter> default_url_loader_factory_getter_; 74 scoped_refptr<URLLoaderFactoryGetter> default_url_loader_factory_getter_;
67 75
68 base::WeakPtr<AppCacheHost> appcache_host_; 76 base::WeakPtr<AppCacheHost> appcache_host_;
69 77
70 DISALLOW_COPY_AND_ASSIGN(AppCacheSubresourceURLFactory); 78 DISALLOW_COPY_AND_ASSIGN(AppCacheSubresourceURLFactory);
71 }; 79 };
72 80
73 } // namespace content 81 } // namespace content
74 82
75 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_FACTORY_H_ 83 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_FACTORY_H_
OLDNEW
« no previous file with comments | « content/browser/appcache/appcache_browsertest.cc ('k') | content/browser/appcache/appcache_subresource_url_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698