Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2985383002: Add partial support for TryFinally and TryCatch statements (Closed)

Created:
3 years, 4 months ago by zhivkag
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add partial support for TryFinally and TryCatch statements BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/72ba4f6c1cb904ea325ea8b293ad6317a41c7f72

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -13 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 2 5 chunks +126 lines, -13 lines 0 comments Download
A pkg/kernel/testcases/interpreter/try_catch_finally_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/interpreter/try_catch_finally_test.dart.expect View 1 chunk +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
zhivkag
This adds partial support for TryFinally and TryCatch by executing the bodies of these statements. ...
3 years, 4 months ago (2017-08-03 07:17:09 UTC) #2
Dmitry Stefantsov
I like it! LGTM.
3 years, 4 months ago (2017-08-03 09:15:52 UTC) #3
zhivkag
3 years, 4 months ago (2017-08-03 10:51:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
72ba4f6c1cb904ea325ea8b293ad6317a41c7f72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698