Add support for finalizer of TryFinally in labeled statements

Add support for finalizer of TryFinally in labeled statements

When a break is encountered in the body of a TryFinally statement to an
enclosing label, the finalizer statement of the TryFinally is executed.


BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/115232ada24265cfb37c1a01302dddbfdf2950e5

[zhivkag, 2017-08-03 11:02:14]

Description was changed from

==========
Add support for finally in labeled statements

BUG=
==========

to

==========
Add support for finalizer of TryFinally in labeled statements

When a break is encountered in the body of a TryFinally statement to an
enclosing label, the finalizer statement of the TryFinally is executed.

 
BUG=
==========

[zhivkag, 2017-08-03 11:02:27]

Description was changed from

==========
Add support for finalizer of TryFinally in labeled statements

When a break is encountered in the body of a TryFinally statement to an
enclosing label, the finalizer statement of the TryFinally is executed.

 
BUG=
==========

to

==========
Add support for finalizer of TryFinally in labeled statements

When a break is encountered in the body of a TryFinally statement to an
enclosing label, the finalizer statement of the TryFinally is executed.

 
BUG=
==========

[zhivkag, 2017-08-03 11:03:17]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[Dmitry Stefantsov, 2017-08-03 13:38:03]

LGTM with a naming suggestion.

https://codereview.chromium.org/2991113002/diff/40001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2991113002/diff/40001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1582: var handlers = new
ExceptionComponents(
Consider renaming [handlers].

[zhivkag, 2017-08-03 14:13:31]

https://codereview.chromium.org/2991113002/diff/40001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2991113002/diff/40001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:1582: var handlers = new
ExceptionComponents(
On 2017/08/03 13:38:03, Dmitry Stefantsov wrote:
> Consider renaming [handlers].

Done.

[zhivkag, 2017-08-03 14:17:32]

Description was changed from

==========
Add support for finalizer of TryFinally in labeled statements

When a break is encountered in the body of a TryFinally statement to an
enclosing label, the finalizer statement of the TryFinally is executed.

 
BUG=
==========

to

==========
Add support for finalizer of TryFinally in labeled statements

When a break is encountered in the body of a TryFinally statement to an
enclosing label, the finalizer statement of the TryFinally is executed.


BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/115232ada24265cfb37c1a01302dddbfdf2950e5
==========

[zhivkag, 2017-08-03 14:17:33]

Committed patchset #4 (id:60001) manually as
115232ada24265cfb37c1a01302dddbfdf2950e5 (presubmit successful).