Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2987153002: Add support for 'throw' expression (Closed)

Created:
3 years, 4 months ago by zhivkag
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 2

Patch Set 3 : Merge #

Patch Set 4 : Merge with master #

Patch Set 5 : Apply comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -3 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 2 3 4 5 chunks +46 lines, -3 lines 0 comments Download
A pkg/kernel/testcases/interpreter/throw_simple_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/interpreter/throw_simple_test.dart.expect View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
zhivkag
3 years, 4 months ago (2017-08-03 07:09:04 UTC) #2
Dmitry Stefantsov
LGTM with one question / comment. Feel free to ignore this if I'm mistaken. https://codereview.chromium.org/2987153002/diff/20001/pkg/kernel/lib/interpreter/interpreter.dart ...
3 years, 4 months ago (2017-08-03 09:01:37 UTC) #3
zhivkag
https://codereview.chromium.org/2987153002/diff/20001/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2987153002/diff/20001/pkg/kernel/lib/interpreter/interpreter.dart#newcode1285 pkg/kernel/lib/interpreter/interpreter.dart:1285: buffer.write('at ${current.expression.toString()}'); On 2017/08/03 09:01:36, Dmitry Stefantsov wrote: > ...
3 years, 4 months ago (2017-08-03 10:35:50 UTC) #4
zhivkag
3 years, 4 months ago (2017-08-03 10:36:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
5e241d86b278045007a4b4277ef472e5c3190b2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698