Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2985273002: [web] Restructure and fix builds. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[web] Restructure and fix builds. Building web apps seems to be broken. Fix it by restructuring the build a bit. Namely: 1) Move application-specific TypeScript into "inc/" so all TS share a root. 2) Update build step to be a little less confusing. BUG=None TEST=local Review-Url: https://codereview.chromium.org/2985273002 Committed: https://github.com/luci/luci-go/commit/a2caef986ff760891a05b460f308bde309d3c37f

Patch Set 1 #

Patch Set 2 : [web] Restructure and fix builds. #

Patch Set 3 : clean #

Patch Set 4 : clean #

Total comments: 4

Patch Set 5 : better globs #

Patch Set 6 : [web] Restructure and fix builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -48 lines) Patch
M web/.gitignore View 1 chunk +2 lines, -2 lines 0 comments Download
M web/apps/gulp-common.js View 1 2 3 4 5 6 chunks +25 lines, -21 lines 0 comments Download
M web/apps/logdog-app/elements/logdog-app/logdog-app.html View 1 chunk +1 line, -1 line 0 comments Download
M web/apps/logdog-app/gulpfile.js View 1 chunk +1 line, -2 lines 0 comments Download
D web/apps/logdog-app/scripts-ts/main.ts View 1 chunk +0 lines, -7 lines 0 comments Download
M web/apps/logdog-view/elements/logdog-view/logdog-view.html View 1 chunk +1 line, -1 line 0 comments Download
M web/apps/logdog-view/gulpfile.js View 1 chunk +1 line, -3 lines 0 comments Download
D web/apps/logdog-view/scripts-ts/logdog-view.ts View 1 chunk +0 lines, -7 lines 0 comments Download
M web/apps/rpcexplorer/gulpfile.js View 1 chunk +1 line, -2 lines 0 comments Download
A + web/inc/apps/logdog-app/main.ts View 1 chunk +1 line, -1 line 0 comments Download
A + web/inc/apps/logdog-view/logdog-view.ts View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
dnj
clean
3 years, 4 months ago (2017-07-28 13:39:55 UTC) #1
dnj
PTAL
3 years, 4 months ago (2017-07-28 13:40:05 UTC) #3
dnj
clean
3 years, 4 months ago (2017-07-28 13:42:42 UTC) #4
dnj
better globs
3 years, 4 months ago (2017-07-28 13:45:36 UTC) #5
Ryan Tseng
lgtm I'm not super familiar with normal gulp stuff and ts project layout https://codereview.chromium.org/2985273002/diff/60001/web/apps/gulp-common.js File ...
3 years, 4 months ago (2017-07-28 13:48:40 UTC) #7
dnj
https://codereview.chromium.org/2985273002/diff/60001/web/apps/gulp-common.js File web/apps/gulp-common.js (right): https://codereview.chromium.org/2985273002/diff/60001/web/apps/gulp-common.js#newcode300 web/apps/gulp-common.js:300: console.log("CURRENT WORKING DIRECTORY MAYBE CHANGE TO APP DIR:", process.cwd()); ...
3 years, 4 months ago (2017-07-28 13:50:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985273002/100001
3 years, 4 months ago (2017-07-28 13:50:50 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-07-28 13:59:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/a2caef986ff760891a05b460f308bde309d3c37f

Powered by Google App Engine
This is Rietveld 408576698