[logdog] Begin migrating to Makefile.

[logdog] Begin migrating to Makefile.

"deploytool" didn't catch on, so begin migrating LogDog's AppEngine
provisioning to a Makefile. This Makefile will consist of two
components: the "luci-go" component, which is a general set of rules to
build, and a deployment component, resident in a separate directory,
which populates some constants and imports the main Makefile.

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2988083002
Committed: https://github.com/luci/luci-go/commit/a8e64660bec91ff303490d6fe7670b847339f1bb

[dnj, 2017-07-28 14:02:45]

formatting

[dnj, 2017-08-01 16:52:33]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-08-01 16:52:34]

PTAL

[Ryan Tseng, 2017-08-01 17:25:49]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-08-01 17:25:50]

fwiw I'm in favor of this change

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/Makefile (right):

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:55: echo "$(CURDIR) $(PWD)."
Whats this for?

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:58: yamls: vmuser/app.yaml
vmuser/dispatch.yaml vmuser/index.yaml
What's this for? (I don't see the deps)

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/backend/module-backend.yaml (right):

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/backend/module-backend.yaml:27: - url: "/.*"
login: admin

[dnj, 2017-08-01 17:37:59]

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/Makefile (right):

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:55: echo "$(CURDIR) $(PWD)."
On 2017/08/01 17:25:50, Ryan Tseng wrote:
> Whats this for?

Debugging, made help a lot better.

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:58: yamls: vmuser/app.yaml
vmuser/dispatch.yaml vmuser/index.yaml
On 2017/08/01 17:25:50, Ryan Tseng wrote:
> What's this for? (I don't see the deps)

This says that the "yamls" target depends on these files existing.

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/backend/module-backend.yaml (right):

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/backend/module-backend.yaml:27: - url: "/.*"
On 2017/08/01 17:25:50, Ryan Tseng wrote:
> login: admin

Done.

[Ryan Tseng, 2017-08-01 17:42:12]

lgtm

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/Makefile (right):

https://codereview.chromium.org/2988083002/diff/60001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:58: yamls: vmuser/app.yaml
vmuser/dispatch.yaml vmuser/index.yaml
On 2017/08/01 17:37:58, dnj wrote:
> On 2017/08/01 17:25:50, Ryan Tseng wrote:
> > What's this for? (I don't see the deps)
> 
> This says that the "yamls" target depends on these files existing.

They always exist? (by virtue of being in the repo)

https://codereview.chromium.org/2988083002/diff/80001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/Makefile (right):

https://codereview.chromium.org/2988083002/diff/80001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:61: deploy-SERVICE: uploads an
instance of the service, but doesn't migrate.
FR: consider switch-SERVICE:
gcloud --project <project> versions migrate $$(gae.py version -A <app> --app-dir
<dir>)

[dnj, 2017-08-01 17:58:27]

https://codereview.chromium.org/2988083002/diff/80001/logdog/appengine/cmd/co...
File logdog/appengine/cmd/coordinator/Makefile (right):

https://codereview.chromium.org/2988083002/diff/80001/logdog/appengine/cmd/co...
logdog/appengine/cmd/coordinator/Makefile:61: deploy-SERVICE: uploads an
instance of the service, but doesn't migrate.
On 2017/08/01 17:42:12, Ryan Tseng wrote:
> FR: consider switch-SERVICE:
> gcloud --project <project> versions migrate $$(gae.py version -A <app>
--app-dir
> <dir>)

Good idea, done.

[dnj, 2017-08-01 18:00:53]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-08-01 18:00:54]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@google.com
Link to the patchset: https://codereview.chromium.org/2988083002/#ps100001
(title: "git checkout view")

[commit-bot: I haz the power, 2017-08-01 18:01:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-01 18:10:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1501610453972520,
"parent_rev": "f91cf2864edce74d3d2fbddaccd27894c97b21a1", "commit_rev":
"a8e64660bec91ff303490d6fe7670b847339f1bb"}

[commit-bot: I haz the power, 2017-08-01 18:10:49]

Description was changed from

==========
[logdog] Begin migrating to Makefile.

"deploytool" didn't catch on, so begin migrating LogDog's AppEngine
provisioning to a Makefile. This Makefile will consist of two
components: the "luci-go" component, which is a general set of rules to
build, and a deployment component, resident in a separate directory,
which populates some constants and imports the main Makefile.

BUG=None
TEST=local
==========

to

==========
[logdog] Begin migrating to Makefile.

"deploytool" didn't catch on, so begin migrating LogDog's AppEngine
provisioning to a Makefile. This Makefile will consist of two
components: the "luci-go" component, which is a general set of rules to
build, and a deployment component, resident in a separate directory,
which populates some constants and imports the main Makefile.

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2988083002
Committed:
https://github.com/luci/luci-go/commit/a8e64660bec91ff303490d6fe7670b847339f1bb
==========

[commit-bot: I haz the power, 2017-08-01 18:10:51]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/a8e64660bec91ff303490d6fe7670b847339f1bb