Remove fields from Isolate in Product mode

Remove fields from Isolate in Product mode

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/13558442ab1b6d77d699ecd79e771b63dc55696b

[zra, 2017-07-24 16:56:24]

zra@google.com changed reviewers:
+ danunez@google.com, rmacnak@google.com

[zra, 2017-07-24 16:56:25]

https://codereview.chromium.org/2984883002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/2984883002/diff/1/runtime/vm/pages.cc#newcode...
runtime/vm/pages.cc:1153: // To avoid waste, the first GC should be triggered
before too long. After
Ryan, Dio, is it okay to skip this adjustment in a Product build?

[rmacnak, 2017-07-24 19:10:36]

lgtm

https://codereview.chromium.org/2984883002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/2984883002/diff/1/runtime/vm/pages.cc#newcode...
runtime/vm/pages.cc:1153: // To avoid waste, the first GC should be triggered
before too long. After
On 2017/07/24 16:56:25, zra wrote:
> Ryan, Dio, is it okay to skip this adjustment in a Product build?

This has the effect of delaying the first GC for slowly allocating programs.  I
think this is fine, and I expect we'll get better memory/idle signals from
Android/iOS/Fuchsia in the future.

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/block_schedu...
File runtime/vm/block_scheduler.cc (right):

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/block_schedu...
runtime/vm/block_scheduler.cc:66:
NOT_IN_PRODUCT(ASSERT(Isolate::Current()->HasAttemptedReload()));
You could also say DEBUG_ASSERT(Isolate::Current()->HasAttemptedReload());

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/heap.cc#newc...
runtime/vm/heap.cc:488: const char* isolate_name = "<unknown>";
Maybe use the regular name field?

[zra, 2017-07-24 20:21:53]

https://codereview.chromium.org/2984883002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/2984883002/diff/1/runtime/vm/pages.cc#newcode...
runtime/vm/pages.cc:1153: // To avoid waste, the first GC should be triggered
before too long. After
On 2017/07/24 19:10:35, rmacnak wrote:
> On 2017/07/24 16:56:25, zra wrote:
> > Ryan, Dio, is it okay to skip this adjustment in a Product build?
> 
> This has the effect of delaying the first GC for slowly allocating programs. 
I
> think this is fine, and I expect we'll get better memory/idle signals from
> Android/iOS/Fuchsia in the future.

Acknowledged.

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/block_schedu...
File runtime/vm/block_scheduler.cc (right):

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/block_schedu...
runtime/vm/block_scheduler.cc:66:
NOT_IN_PRODUCT(ASSERT(Isolate::Current()->HasAttemptedReload()));
On 2017/07/24 19:10:35, rmacnak wrote:
> You could also say DEBUG_ASSERT(Isolate::Current()->HasAttemptedReload());

Done.

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

https://codereview.chromium.org/2984883002/diff/20001/runtime/vm/heap.cc#newc...
runtime/vm/heap.cc:488: const char* isolate_name = "<unknown>";
On 2017/07/24 19:10:36, rmacnak wrote:
> Maybe use the regular name field?

Done.

[zra, 2017-07-24 20:22:48]

Description was changed from

==========
Remove fields from Isolate in Product mode
==========

to

==========
Remove fields from Isolate in Product mode

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/13558442ab1b6d77d699ecd79e771b63dc55696b
==========

[zra, 2017-07-24 20:22:49]

Committed patchset #3 (id:40001) manually as
13558442ab1b6d77d699ecd79e771b63dc55696b (presubmit successful).