Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: runtime/vm/parser.cc

Issue 2984883002: Remove fields from Isolate in Product mode (Closed)
Patch Set: Address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/pages.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index f555b6d62fb2da5536b4ba7e7cde3f1842b389e1..004956688b7c8463f5bd63582f8fb6af59a1202f 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -1612,7 +1612,7 @@ SequenceNode* Parser::ParseImplicitClosure(const Function& func) {
const Class& owner = Class::Handle(parent.Owner());
Function& target = Function::ZoneHandle(owner.LookupFunction(func_name));
if (target.raw() != parent.raw()) {
- ASSERT(Isolate::Current()->HasAttemptedReload());
+ NOT_IN_PRODUCT(ASSERT(Isolate::Current()->HasAttemptedReload()));
if (target.IsNull() || (target.is_static() != parent.is_static()) ||
(target.kind() != parent.kind())) {
target = Function::null();
@@ -1628,7 +1628,7 @@ SequenceNode* Parser::ParseImplicitClosure(const Function& func) {
(parent.num_fixed_parameters() == target.num_fixed_parameters())) {
call = new StaticCallNode(token_pos, target, func_args);
} else if (!parent.is_static()) {
- ASSERT(Isolate::Current()->HasAttemptedReload());
+ NOT_IN_PRODUCT(ASSERT(Isolate::Current()->HasAttemptedReload()));
// If a subsequent reload reintroduces the target in the middle of the
// Invocation object being constructed, we won't be able to successfully
// deopt because the generated AST will change.
@@ -1651,7 +1651,7 @@ SequenceNode* Parser::ParseImplicitClosure(const Function& func) {
}
call = new StaticCallNode(token_pos, no_such_method, arguments);
} else {
- ASSERT(Isolate::Current()->HasAttemptedReload());
+ NOT_IN_PRODUCT(ASSERT(Isolate::Current()->HasAttemptedReload()));
// If a subsequent reload reintroduces the target in the middle of the
// arguments array being constructed, we won't be able to successfully
// deopt because the generated AST will change.
« no previous file with comments | « runtime/vm/pages.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698