Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2984803002:
Fix the order of incluson. (Closed)
|
Created:
3 years, 5 months ago by njanevsk Modified:
3 years, 5 months ago Reviewers:
Sébastien Marchand CC:
syzygy-changes_googlegroups.com Target Ref:
refs/heads/master Project:
syzygy Visibility:
Public. |
DescriptionFix the order of incluson.
BUG=
Review-Url: https://codereview.chromium.org/2984803002
Committed: https://github.com/google/syzygy/commit/278dae99a4f8b022bc4ea1e52936a79457b26dd3
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix the order of incluson. #
Total comments: 1
Patch Set 3 : Fix the order of incluson. #Messages
Total messages: 17 (9 generated)
Description was changed from ========== Fix the order of incluson. BUG= ========== to ========== Fix the order of incluson. BUG= ==========
njanevsk@google.com changed reviewers: + sebmarchand@chromium.org
One liner. PTAL.
https://codereview.chromium.org/2984803002/diff/1/syzygy/integration_tests/in... File syzygy/integration_tests/integration_tests_dll.h (right): https://codereview.chromium.org/2984803002/diff/1/syzygy/integration_tests/in... syzygy/integration_tests/integration_tests_dll.h:199: END_TO_END_ASAN_TESTS(decl) END_TO_END_NON_ASAN_TESTS(decl) Please add a comment to indicate that the order matters.
On 2017/07/21 15:04:15, Sébastien Marchand wrote: > https://codereview.chromium.org/2984803002/diff/1/syzygy/integration_tests/in... > File syzygy/integration_tests/integration_tests_dll.h (right): > > https://codereview.chromium.org/2984803002/diff/1/syzygy/integration_tests/in... > syzygy/integration_tests/integration_tests_dll.h:199: > END_TO_END_ASAN_TESTS(decl) END_TO_END_NON_ASAN_TESTS(decl) > Please add a comment to indicate that the order matters. Done. PTAL.
PTAL https://codereview.chromium.org/2984803002/diff/1/syzygy/integration_tests/in... File syzygy/integration_tests/integration_tests_dll.h (right): https://codereview.chromium.org/2984803002/diff/1/syzygy/integration_tests/in... syzygy/integration_tests/integration_tests_dll.h:199: END_TO_END_ASAN_TESTS(decl) END_TO_END_NON_ASAN_TESTS(decl) On 2017/07/21 15:04:15, Sébastien Marchand wrote: > Please add a comment to indicate that the order matters. Done.
lgtm https://codereview.chromium.org/2984803002/diff/20001/syzygy/integration_test... File syzygy/integration_tests/integration_tests_dll.h (right): https://codereview.chromium.org/2984803002/diff/20001/syzygy/integration_test... syzygy/integration_tests/integration_tests_dll.h:195: // The order of inclusion matters because it affects the numbers assigned to s/numbers/IDs/
The CQ bit was checked by njanevsk@google.com
The CQ bit was unchecked by njanevsk@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by njanevsk@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sebmarchand@chromium.org Link to the patchset: https://codereview.chromium.org/2984803002/#ps20002 (title: "Fix the order of incluson.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20002, "attempt_start_ts": 1500650225560070,
"parent_rev": "21968e40c08a1c95d00862422ff30dda237317e7", "commit_rev":
"278dae99a4f8b022bc4ea1e52936a79457b26dd3"}
Message was sent while issue was closed.
Description was changed from ========== Fix the order of incluson. BUG= ========== to ========== Fix the order of incluson. BUG= Review-Url: https://codereview.chromium.org/2984803002 Committed: https://github.com/google/syzygy/commit/278dae99a4f8b022bc4ea1e52936a79457b26dd3 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:20002) as https://github.com/google/syzygy/commit/278dae99a4f8b022bc4ea1e52936a79457b26dd3
Message was sent while issue was closed.
Patchset #4 (id:50001) has been deleted |
