Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: syzygy/integration_tests/integration_tests_dll.h

Issue 2984803002: Fix the order of incluson. (Closed)
Patch Set: Fix the order of incluson. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/integration_tests/integration_tests_dll.h
diff --git a/syzygy/integration_tests/integration_tests_dll.h b/syzygy/integration_tests/integration_tests_dll.h
index 8c448381e8ebdf5b083986a193e11dac84d1a591..9df79fd63d4e00f94a00327d8b2edeeb272c5e80 100644
--- a/syzygy/integration_tests/integration_tests_dll.h
+++ b/syzygy/integration_tests/integration_tests_dll.h
@@ -192,11 +192,13 @@ namespace testing {
decl(kProfileGetMyRVA, testing::GetMyRVA)
// Only run the Asan tests for the Clang builds.
+// The order of inclusion matters because it affects the IDs assigned to
+// test cases. First include Asan tests then non Asan tests.
#ifdef __clang__
#define END_TO_END_TEST_ID_TABLE(decl) END_TO_END_ASAN_TESTS(decl)
#else
#define END_TO_END_TEST_ID_TABLE(decl) \
- END_TO_END_NON_ASAN_TESTS(decl) END_TO_END_ASAN_TESTS(decl)
+ END_TO_END_ASAN_TESTS(decl) END_TO_END_NON_ASAN_TESTS(decl)
#endif // __clang__
// This enumeration contains an unique id for each end to end test. It is used
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698