Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2984143002:
Milo Swarmbucket: Use got_revision as revision (Closed)
|
Created:
3 years, 5 months ago by Ryan Tseng Modified:
3 years, 4 months ago CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
DescriptionMilo Swarmbucket: Use got_revision as revision
The intended effect is that this gets placed in the revision field, which would then become indexed for console view.
BUG=468053
Review-Url: https://codereview.chromium.org/2984143002
Committed: https://github.com/luci/luci-go/commit/93d0bb0680c0244e179b339d92c39b76a06c7f8d
Patch Set 1 #Patch Set 2 : Retrain #Patch Set 3 : Revert proto update... #Patch Set 4 : Rebase #
Depends on Patchset: Messages
Total messages: 35 (25 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/378dbf805f75cd10) Luci-go Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/378dbf80a9255510)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Milo: HACKS BUG= ========== to ========== Milo Swarmbucket: Use got_revision as revision BUG=468053 ==========
hinoka@google.com changed reviewers: + iannucci@chromium.org
ptal
Description was changed from ========== Milo Swarmbucket: Use got_revision as revision BUG=468053 ========== to ========== Milo Swarmbucket: Use got_revision as revision The intended effect is that this gets placed in the revision field, which would then become indexed for console view. BUG=468053 ==========
hinoka@google.com changed reviewers: + dnj@chromium.org
ptal? This is sort of a hack, but it's more or less what me and robbie agreed on doing until source manifests become a thing.
lgtm but ewwww
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/37b8435a51bcce10)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hinoka@google.com
The CQ bit was checked by hinoka@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2984143002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/37b84fb3ce939510)
On 2017/08/01 20:35:37, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > Luci-go Win Tester on luci.infra.try (JOB_FAILED, > https://luci-milo.appspot.com/swarming/task/37b84fb3ce939510) already filed a bug for this failure https://crbug.com/751229
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1501631001078270,
"parent_rev": "379385244aafd8eaf3342455774d102f17263a45", "commit_rev":
"93d0bb0680c0244e179b339d92c39b76a06c7f8d"}
Message was sent while issue was closed.
Description was changed from ========== Milo Swarmbucket: Use got_revision as revision The intended effect is that this gets placed in the revision field, which would then become indexed for console view. BUG=468053 ========== to ========== Milo Swarmbucket: Use got_revision as revision The intended effect is that this gets placed in the revision field, which would then become indexed for console view. BUG=468053 Review-Url: https://codereview.chromium.org/2984143002 Committed: https://github.com/luci/luci-go/commit/93d0bb0680c0244e179b339d92c39b76a06c7f8d ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://github.com/luci/luci-go/commit/93d0bb0680c0244e179b339d92c39b76a06c7f8d |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
