Milo Swarmbucket: Use got_revision as revision

milo/buildsource/rawpresentation/logDogBuild.go

 // Copyright 2016 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 package rawpresentation
 
 import (
+        "encoding/json"
         "fmt"
         "time"
 
         "golang.org/x/net/context"
 
         "github.com/luci/luci-go/common/clock"
         "github.com/luci/luci-go/common/proto/google"
         miloProto "github.com/luci/luci-go/common/proto/milo"
         "github.com/luci/luci-go/milo/api/resp"
         "github.com/luci/luci-go/milo/common/model"
@@ skipping 170 matching lines @@
 // AddLogDogToBuild takes a set of logdog streams and populate a milo build.
 // build.Summary.Finished must be set.
 func AddLogDogToBuild(
         c context.Context, ub URLBuilder, mainAnno *miloProto.Step, build *resp.MiloBuild) {
         now := clock.Now(c)
 
         // Now fill in each of the step components.
         // TODO(hinoka): This is totes cachable.
         buildCompletedTime := google.TimeFromProto(mainAnno.Ended)
         build.Summary = *(miloBuildStep(ub, mainAnno, true, buildCompletedTime, now)[0])
+        propMap := map[string]string{}
         for _, substepContainer := range mainAnno.Substep {
                 anno := substepContainer.GetStep()
                 if anno == nil {
                         // TODO: We ignore non-embedded substeps for now.
                         continue
                 }
 
                 bss := miloBuildStep(ub, anno, false, buildCompletedTime, now)
                 for _, bs := range bss {
                         if bs.Status != model.Success {
                                 build.Summary.Text = append(
                                         build.Summary.Text, fmt.Sprintf("%s %s", bs.Status, bs.Label))
                         }
                         build.Components = append(build.Components, bs)
                         propGroup := &resp.PropertyGroup{GroupName: bs.Label}
                         for _, prop := range anno.Property {
                                 propGroup.Property = append(propGroup.Property, &resp.Property{
                                         Key:   prop.Name,
                                         Value: prop.Value,
                                 })
+                                propMap[prop.Name] = prop.Value
                         }
                         build.PropertyGroup = append(build.PropertyGroup, propGroup)
                 }
         }
 
         // Take care of properties
         propGroup := &resp.PropertyGroup{GroupName: "Main"}
         for _, prop := range mainAnno.Property {
                 propGroup.Property = append(propGroup.Property, &resp.Property{
                         Key:   prop.Name,
                         Value: prop.Value,
                 })
+                propMap[prop.Name] = prop.Value
         }
         build.PropertyGroup = append(build.PropertyGroup, propGroup)
 
+        // HACK(hinoka,iannucci): Extract revision out of properties.
+        if jrev, ok := propMap["got_revision"]; ok {
+                // got_revision is a json string, so it looks like "aaaaaabbcc123..."
+                var rev string
+                err := json.Unmarshal([]byte(jrev), &rev)
+                if err == nil {
+                        if build.SourceStamp == nil {
+                                build.SourceStamp = &resp.SourceStamp{}
+                        }
+                        build.SourceStamp.Revision = resp.NewLink(
+                                rev, fmt.Sprintf("https://crrev.com/%s", rev))
+                }
+        }
+
         return
 }