Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2983783002: Run the integration tests against the Clang instrumented DLL. (Closed)

Created:
3 years, 5 months ago by Sébastien Marchand
Modified:
3 years, 3 months ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

This make the integration tests also use the Clang version of the test DLL. None of the tests has been modified. Review-Url: https://codereview.chromium.org/2983783002 Committed: https://github.com/google/syzygy/commit/9de882bf08f7a2af66b6ce233da3644b9c988a6a

Patch Set 1 #

Patch Set 2 : [DO NOT COMMIT] Prototype for the Clang integration tests. #

Patch Set 3 : Shim POC #

Patch Set 4 : Shim POC #

Patch Set 5 : env #

Patch Set 6 : Almost working #

Patch Set 7 : It works! #

Patch Set 8 : Rebase #

Patch Set 9 : It works! #

Patch Set 10 : rebase #

Patch Set 11 : Rebase #

Patch Set 12 : Rebase #

Patch Set 13 : remove dead code. #

Total comments: 1

Patch Set 14 : Address Chris comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -105 lines) Patch
M syzygy/integration_tests/asan_interceptors_tests.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +15 lines, -2 lines 0 comments Download
M syzygy/integration_tests/asan_interceptors_tests.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M syzygy/integration_tests/instrument_integration_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +106 lines, -103 lines 0 comments Download
M syzygy/pe/unittest_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M syzygy/pe/unittest_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Sébastien Marchand
PTAL
3 years, 3 months ago (2017-08-30 00:43:55 UTC) #3
chrisha
lgtm! https://codereview.chromium.org/2983783002/diff/240001/syzygy/integration_tests/asan_interceptors_tests.h File syzygy/integration_tests/asan_interceptors_tests.h (right): https://codereview.chromium.org/2983783002/diff/240001/syzygy/integration_tests/asan_interceptors_tests.h#newcode42 syzygy/integration_tests/asan_interceptors_tests.h:42: return *location; You don't need the try/except for ...
3 years, 3 months ago (2017-08-30 16:55:32 UTC) #4
Sébastien Marchand
On 2017/08/30 16:55:32, chrisha wrote: > lgtm! > > https://codereview.chromium.org/2983783002/diff/240001/syzygy/integration_tests/asan_interceptors_tests.h > File syzygy/integration_tests/asan_interceptors_tests.h (right): > ...
3 years, 3 months ago (2017-08-31 17:46:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983783002/260001
3 years, 3 months ago (2017-08-31 17:49:23 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-08-31 17:49:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #14 (id:260001) as
https://github.com/google/syzygy/commit/9de882bf08f7a2af66b6ce233da3644b9c988a6a

Powered by Google App Engine
This is Rietveld 408576698