Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: syzygy/integration_tests/asan_interceptors_tests.cc

Issue 2983783002: Run the integration tests against the Clang instrumented DLL. (Closed)
Patch Set: Address Chris comment. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/integration_tests/asan_interceptors_tests.cc
diff --git a/syzygy/integration_tests/asan_interceptors_tests.cc b/syzygy/integration_tests/asan_interceptors_tests.cc
index 7a48f49bde737a4164d307a82b073408ac1881b2..36a8ecc8a7cb86c70712a2ab3a5bbd1814ee73df 100644
--- a/syzygy/integration_tests/asan_interceptors_tests.cc
+++ b/syzygy/integration_tests/asan_interceptors_tests.cc
@@ -1145,6 +1145,9 @@ size_t AsanCorruptBlock() {
}
size_t AsanCorruptBlockInQuarantine() {
+ // This test requires the HeapCreate/HeapDestroy functions to be intercepted
+ // and so doesn't work with a Clang-instrumented binary.
+ // TODO(sebmarchand): Find another way to flush the quarantine.
HANDLE heap = ::HeapCreate(NULL, 0, 0);
size_t* mem =
static_cast<size_t*>(::HeapAlloc(heap, NULL, 10 * sizeof(size_t)));
« no previous file with comments | « syzygy/integration_tests/asan_interceptors_tests.h ('k') | syzygy/integration_tests/instrument_integration_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698