Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2983143002: Revert of Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() (Closed)

Created:
3 years, 5 months ago by robliao
Modified:
3 years, 5 months ago
Reviewers:
Reid Kleckner, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() (patchset #1 id:1 of https://codereview.chromium.org/2978253002/ ) Reason for revert: Causes base/task_scheduler/scheduler_worker.h(199,40): error: private field 'backward_compatibility_' is not used [-Werror,-Wunused-private-field] const SchedulerBackwardCompatibility backward_compatibility_; Original issue's description: > Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() > > This change will allow for the detection of tasks running in > TaskScheduler that fail to post their task in a COM STA Task Runner > instead. > > BUG=706512 > TBR=gab@chromium.org > Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ > > Review-Url: https://codereview.chromium.org/2978253002 > Cr-Commit-Position: refs/heads/master@{#487625} > Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f TBR=gab@chromium.org,rnk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=706512 Review-Url: https://codereview.chromium.org/2983143002 Cr-Commit-Position: refs/heads/master@{#488089} Committed: https://chromium.googlesource.com/chromium/src/+/9d02b58c2721f40f9b1f89af4fde464b6531360d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M base/task_scheduler/scheduler_worker.cc View 2 chunks +1 line, -5 lines 0 comments Download
M base/task_scheduler/scheduler_worker_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
robliao
Created Revert of Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED()
3 years, 5 months ago (2017-07-20 00:30:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983143002/1
3 years, 5 months ago (2017-07-20 00:31:07 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 01:48:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d02b58c2721f40f9b1f89af4fde...

Powered by Google App Engine
This is Rietveld 408576698