Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2978253002:
Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() (Closed)
DescriptionDisable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED()
This change will allow for the detection of tasks running in
TaskScheduler that fail to post their task in a COM STA Task Runner
instead.
BUG=706512
TBR=gab@chromium.org
Previously Reviewed at https://chromium-review.googlesource.com/c/549223/
Review-Url: https://codereview.chromium.org/2978253002
Cr-Original-Commit-Position: refs/heads/master@{#487625}
Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f
Review-Url: https://codereview.chromium.org/2978253002
Cr-Commit-Position: refs/heads/master@{#488327}
Committed: https://chromium.googlesource.com/chromium/src/+/8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65
Patch Set 1 #Patch Set 2 : Fixed Unused Private Field #
Messages
Total messages: 30 (18 generated)
Description was changed from ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 ========== to ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ ==========
robliao@chromium.org changed reviewers: + gab@chromium.org
TBR'ing gab@ as this was previously reviewed at https://chromium-review.googlesource.com/c/549223/
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by robliao@chromium.org
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1500415348721270, "parent_rev":
"4b0f95046cab6b58afa33f55f52f1bfe457af947", "commit_rev":
"122a24f59d90a1b225e00b3ab6c9fd37fd365b8f"}
Message was sent while issue was closed.
Description was changed from ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ ========== to ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9...
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
rnk@chromium.org changed reviewers: + rnk@chromium.org
Message was sent while issue was closed.
This seems to have caused a -Wunused-private-field in some clang builds: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTW... Maybe these builds are official vs. non-official? Anyway, can you take a look?
Message was sent while issue was closed.
On 2017/07/20 00:21:36, Reid Kleckner wrote: > This seems to have caused a -Wunused-private-field in some clang builds: > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTW... > > Maybe these builds are official vs. non-official? Anyway, can you take a look? These will most definitely be official vs non-official. This flag is only active on x86 non-official builds.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2983143002/ by robliao@chromium.org. The reason for reverting is: Causes base/task_scheduler/scheduler_worker.h(199,40): error: private field 'backward_compatibility_' is not used [-Werror,-Wunused-private-field] const SchedulerBackwardCompatibility backward_compatibility_;.
Message was sent while issue was closed.
Description was changed from ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9... ========== to ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9... ==========
Added a patch to fix the unused private field.
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org Link to the patchset: https://codereview.chromium.org/2978253002/#ps20001 (title: "Fixed Unused Private Field")
The CQ bit was unchecked by robliao@chromium.org
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500571568728360,
"parent_rev": "025b91e31ca2dff02a403ef484150c8258178c98", "commit_rev":
"8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65"}
Message was sent while issue was closed.
Description was changed from ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9... ========== to ========== Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Original-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9... Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#488327} Committed: https://chromium.googlesource.com/chromium/src/+/8f9efe1f0d7e7d5c1c186f31a529... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8f9efe1f0d7e7d5c1c186f31a529... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
