Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2982893002: Reland of Make /deep/ as no-op and remove ::shadow in dynamic profile (Closed)

Created:
3 years, 5 months ago by Alexander Alekseev
Modified:
3 years, 5 months ago
Reviewers:
rkc, achuithb, hayato, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make /deep/ as no-op and remove ::shadow in dynamic profile (patchset #1 id:1 of https://codereview.chromium.org/2885153003/ ) Reason for revert: CrOS OOBE doesn't depend on /deep/ anymore. Original issue's description: > Revert of Make /deep/ as no-op and remove ::shadow in dynamic profile (patchset #9 id:160001 of https://codereview.chromium.org/2778983006/ ) > > Reason for revert: > (from the right account this time) Completely breaks Chrome OS login UI > > Original issue's description: > > Make /deep/ as no-op and remove ::shadow in dynamic profile > > > > Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns > > > > To make this CL small one, and easy to be reverted, all tests which depend on /deep/ > > (or ::shadow) were either removed or updated in another CL: > > https://bugs.chromium.org/p/chromium/issues/detail?id=715034. > > > > This CL only touched the small part so that users can't use /deep/ or ::shadow > > in CSS dynamic profile in M60. The further internal clean up is needed in other CLs. > > > > BUG=489954 > > > > Review-Url: https://codereview.chromium.org/2778983006 > > Cr-Commit-Position: refs/heads/master@{#471684} > > Committed: https://chromium.googlesource.com/chromium/src/+/a7ab8a110bd6b5339c03a34a5a6bb9a419a49e60 > > TBR=achuith@chromium.org,alemate@chromium.org,kochi@chromium.org,hayato@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=489954 > > Review-Url: https://codereview.chromium.org/2885153003 > Cr-Commit-Position: refs/heads/master@{#472295} > Committed: https://chromium.googlesource.com/chromium/src/+/bffed136492ff2507a9b5c5e484dc9229b595dbe TBR=achuith@chromium.org,kochi@chromium.org,hayato@chromium.org,rkc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=489954

Patch Set 1 #

Messages

Total messages: 11 (3 generated)
Alexander Alekseev
Created Reland of Make /deep/ as no-op and remove ::shadow in dynamic profile
3 years, 5 months ago (2017-07-14 22:45:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982893002/1
3 years, 5 months ago (2017-07-14 22:45:33 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/259049)
3 years, 5 months ago (2017-07-14 22:48:34 UTC) #5
achuithb
lgtm
3 years, 5 months ago (2017-07-14 22:49:30 UTC) #6
hayato
It looks the patch isn't applied any more, I guess. alemate@, do you want to ...
3 years, 5 months ago (2017-07-18 04:02:37 UTC) #7
Alexander Alekseev
On 2017/07/18 04:02:37, hayato wrote: > It looks the patch isn't applied any more, I ...
3 years, 5 months ago (2017-07-18 04:19:52 UTC) #8
hayato
On 2017/07/18 at 04:19:52, alemate wrote: > On 2017/07/18 04:02:37, hayato wrote: > > It ...
3 years, 5 months ago (2017-07-18 04:44:57 UTC) #9
Alexander Alekseev
3 years, 5 months ago (2017-07-18 04:46:37 UTC) #11
Message was sent while issue was closed.
On 2017/07/18 04:44:57, hayato wrote:
> On 2017/07/18 at 04:19:52, alemate wrote:
> > On 2017/07/18 04:02:37, hayato wrote:
> > > It looks the patch isn't applied any more, I guess.
> > > 
> > > alemate@, do you want to rebase it? If you can't, I am feeling that I
should
> do
> > > it.
> > 
> > I sent you on Friday:
> > HI, the CL to remove /deep/ support conflicts with current code. Could I
pass
> https://bugs.chromium.org/p/chromium/issues/detail?id=723259 to you, as you
know
> this code better ;) ?
> > 
> > It would be great if you could rebase it.
> 
> Sure. Let me do it. You can close this review, I think.

Thank you!

Powered by Google App Engine
This is Rietveld 408576698