Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2981863002: Revert of Override rtc::Event with Chromium's implementation (Closed)

Created:
3 years, 5 months ago by tommi (sloooow) - chröme
Modified:
3 years, 5 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Override rtc::Event with Chromium's implementation (patchset #2 id:20001 of https://codereview.chromium.org/2975553002/ ) Reason for revert: Reverting temporarily until the webrtc change can be rolled with it. Original issue's description: > Preparation of overriding WebRTC's rtc::Event with Chromium's implementation. > This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). > > Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. > > BUG=689520 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2975553002 > Cr-Commit-Position: refs/heads/master@{#486737} > Committed: https://chromium.googlesource.com/chromium/src/+/07019da77f12dc06fd8a2e66061c8a79c90bc439 TBR=grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689520 Review-Url: https://codereview.chromium.org/2981863002 Cr-Commit-Position: refs/heads/master@{#486739} Committed: https://chromium.googlesource.com/chromium/src/+/8b70da209684e205d2ca7a363887715f0c8285be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -73 lines) Patch
D third_party/webrtc_overrides/webrtc/rtc_base/event.h View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/webrtc_overrides/webrtc/rtc_base/event.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tommi (sloooow) - chröme
Created Revert of Override rtc::Event with Chromium's implementation
3 years, 5 months ago (2017-07-14 11:50:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981863002/1
3 years, 5 months ago (2017-07-14 11:50:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8b70da209684e205d2ca7a363887715f0c8285be
3 years, 5 months ago (2017-07-14 11:51:24 UTC) #6
Henrik Grunell
3 years, 5 months ago (2017-07-14 11:57:23 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698