Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2975553002: Override rtc::Event with Chromium's implementation (Closed)

Created:
3 years, 5 months ago by tommi (sloooow) - chröme
Modified:
3 years, 5 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Preparation of overriding WebRTC's rtc::Event with Chromium's implementation. This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. BUG=689520 NOTRY=true Review-Url: https://codereview.chromium.org/2975553002 Cr-Commit-Position: refs/heads/master@{#486737} Committed: https://chromium.googlesource.com/chromium/src/+/07019da77f12dc06fd8a2e66061c8a79c90bc439

Patch Set 1 #

Patch Set 2 : Move and update files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A third_party/webrtc_overrides/webrtc/rtc_base/event.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/webrtc_overrides/webrtc/rtc_base/event.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
tommi1
3 years, 5 months ago (2017-07-13 21:09:02 UTC) #4
tommi (sloooow) - chröme
Hej Henrik - please take a look. The code is inactive as is, hence the ...
3 years, 5 months ago (2017-07-13 21:10:42 UTC) #7
Henrik Grunell
Looks good, but should it be webrtc/rtc_base/event.h/cc that are overridden? webrtc/base/event.h is deprecated. https://cs.chromium.org/chromium/src/third_party/webrtc/base/event.h?q=webrtc/base/event.h&sq=package:chromium&l=15
3 years, 5 months ago (2017-07-14 10:25:48 UTC) #8
tommi (sloooow) - chröme
Move and update files
3 years, 5 months ago (2017-07-14 10:40:56 UTC) #9
tommi (sloooow) - chröme
ah indeed! thanks for catching that (I started this CL one week ago, I guess ...
3 years, 5 months ago (2017-07-14 10:41:12 UTC) #10
Henrik Grunell
lgtm
3 years, 5 months ago (2017-07-14 10:46:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975553002/20001
3 years, 5 months ago (2017-07-14 11:37:19 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/07019da77f12dc06fd8a2e66061c8a79c90bc439
3 years, 5 months ago (2017-07-14 11:42:23 UTC) #16
tommi (sloooow) - chröme
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2981863002/ by tommi@chromium.org. ...
3 years, 5 months ago (2017-07-14 11:50:41 UTC) #17
findit-for-me
3 years, 5 months ago (2017-07-14 11:59:28 UTC) #18
Message was sent while issue was closed.
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 486737 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698