Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 298163003: Fix crash in the flakiness dashboard server. (Closed)

Created:
6 years, 7 months ago by ojan
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fix crash in the flakiness dashboard server. In theory, this case should never happen, but clearly there's a bug somewhere. I don't have time to dig into the bug right now, so just bandaid over it by returning the empty string. This will mean the old data is lost, since we basically treat this as an empty file, but at least we start collecting the new data. We'll still log the error though, so we can grep the log to find these cases in the future and fix them. BUG=377594 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M Tools/TestResultServer/model/datastorefile.py View 1 chunk +6 lines, -1 line 0 comments Download
M Tools/TestResultServer/model/datastorefile_test.py View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 7 months ago (2014-05-27 01:02:45 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-05-28 19:05:32 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-05-28 20:09:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/298163003/1
6 years, 6 months ago (2014-05-28 20:09:36 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 20:31:51 UTC) #5
Message was sent while issue was closed.
Change committed as 174990

Powered by Google App Engine
This is Rietveld 408576698